Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COSM integration, separation of library and script #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vzaliva
Copy link

@vzaliva vzaliva commented May 17, 2013

Please take a look at some changes I did and feel free to merge them if you find them useful. Major ones:

  1. Separated command line script from library, so the library could be used by other scripts
  2. Added script to upload nest data to COSM.com

Vadim

@evilpete
Copy link

the splitting into a script & lib makes some sense ( although not necessary )

I do not see the reason to integrate COSM.com into the primary nest library, any 3party site features should be in they own repository or added to a example apps sub directory

eg: in my API lib for the ISY home controller I add a separate script program to that uses nest features as an example application [ https://github.com/evilpete/ISYlib-python/blob/master/bin/isy_nestset.py]

@vzaliva
Copy link
Author

vzaliva commented May 18, 2013

I agree in general but it depends on your definitions of the library. The core nest communications and COSM functionality are separate modules, just packaged together. One can use PYNEST module without COSM but not another way around.

I can keep COSM integration stuff in my repository. What I would love to is to be able to install PYNEST as a python module and use it as an external dependency instead of packaging it with my code. For this the separation of the script and the library is necessary. Setuptools install library modules in python path and I can easily import them. Currently the script is installed in different directory and I could not import it without knowing the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants