Fix Domoticz re-subscribe on MQTT reconnect. Regression from v13.4.0.3 (

arendst#21281)
smcgann99 · May 16, 2024 · 6ba5938 · 6ba5938
1 parent f602470
commit 6ba5938
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,9 +13,10 @@ All notable changes to this project will be documented in this file.
 - ESP32 compiler option from `target-align` to `no-target-align` (#21407)
 
 ### Fixed
+- Domoticz re-subscribe on MQTT reconnect. Regression from v13.4.0.3 (#21281)
 
 ### Removed
-- Support of old insecure fingerprint algorithm - deprecated since v8.4.0 (#21417)
+- Support of old insecure fingerprint algorithm. Deprecated since v8.4.0 (#21417)
 
 ## [Released]
 

diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -128,6 +128,7 @@ The latter links can be used for OTA upgrades too like ``OtaUrl https://ota.tasm
 - ESP32 compiler option from `target-align` to `no-target-align` [#21407](https://github.com/arendst/Tasmota/issues/21407)
 
 ### Fixed
+- Domoticz re-subscribe on MQTT reconnect. Regression from v13.4.0.3 [#21281](https://github.com/arendst/Tasmota/issues/21281)
 
 ### Removed
-- Support of old insecure fingerprint algorithm - deprecated since v8.4.0 [#21417](https://github.com/arendst/Tasmota/issues/21417)
+- Support of old insecure fingerprint algorithm. Deprecated since v8.4.0 [#21417](https://github.com/arendst/Tasmota/issues/21417)
diff --git a/tasmota/tasmota_xdrv_driver/xdrv_07_domoticz.ino b/tasmota/tasmota_xdrv_driver/xdrv_07_domoticz.ino
@@ -232,7 +232,8 @@ void DomoticzMqttSubscribe(void) {
     Domoticz->subscribe = false;
     MqttUnsubscribe(stopic);
   }
-  if (!Domoticz->subscribe && any_relay) {
+//  if (!Domoticz->subscribe && any_relay) {  // Fails on MQTT server reconnect
+  if (any_relay) {
     Domoticz->subscribe = true;
     MqttSubscribe(stopic);
   }