feat: make polling to par with android #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| request: request, | ||
| interval: 1, | ||
| numAttempts: 30 | ||
| ) | ||
| var response : JobStatusResponse<JobResult>? = nil |
There was a problem hiding this comment.
⚠️ Initializing an optional variable with nil is redundant. (redundant_optional_initialization)
Generated by 🚫 Danger Swift against dc98712 |
tobitech
approved these changes
Aug 6, 2024
| @@ -13,11 +14,11 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| didFinishLaunchingWithOptions _: [UIApplication.LaunchOptionsKey: Any]? | |||
| ) -> Bool { | |||
| UINavigationBar.appearance().titleTextAttributes = [ | |||
| NSAttributedString.Key.foregroundColor: UIColor.black | |||
| NSAttributedString.Key.foregroundColor: UIColor.black, | |||
There was a problem hiding this comment.
Please resolve trailing_comma warning.
| } catch { | ||
| latestError = error | ||
| } | ||
| try await Task.sleep(nanoseconds: UInt64(interval * 1_000_000_000)) |
There was a problem hiding this comment.
Could you please explain why you're introducing this delay? I think this can slow down the code execution.
There was a problem hiding this comment.
Already discussed this during our sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: TIMEOUT FIXES FOR IOS
Summary
For polling iOS would run and when the maximum attempts has been reached it'd throw a timeout exception. Android on the other hand returns the last response when the maximum attempt is reached and it's a flow. This PR attempts to copy functionality on android to iOS so that they work the same way
Known Issues
N/A
Test Instructions
Run any product polling to confirm