You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap zip library implementation on iOS to zip in memory
Known Issues
Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.
Test Instructions
Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.
Screenshot
If applicable (e.g. UI changes), add screenshots to help explain your work.
The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️
Sources/SmileID/Classes/BiometricKYC/OrchestratedBiometricKycViewModel.swift#L105 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)
⚠️
Sources/SmileID/Classes/DocumentVerification/Model/OrchestratedDocumentVerificationViewModel.swift#L109 - Function should have complexity 10 or less: currently complexity equals 14 (cyclomatic_complexity)
⚠️
Sources/SmileID/Classes/DocumentVerification/Model/OrchestratedDocumentVerificationViewModel.swift#L184 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)
⚠️
Sources/SmileID/Classes/DocumentVerification/Model/OrchestratedDocumentVerificationViewModel.swift#L301 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
⚠️
Sources/SmileID/Classes/Helpers/LocalStorage.swift#L174 - Lines should not have trailing whitespace. (trailing_whitespace)
⚠️
Sources/SmileID/Classes/SmileID.swift#L113 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)
⚠️
Sources/SmileID/Classes/SmileID.swift#L139 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jumaallan
force-pushed
the
feat/swap-zi-library
branch
from
Story: https://app.shortcut.com/smileid/story/12554/ios-integrate-with-new-zip-library
Summary
Swap zip library implementation on iOS to zip in memory
Known Issues
Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.
Test Instructions
Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.
Screenshot
If applicable (e.g. UI changes), add screenshots to help explain your work.