Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/smilescreens #236

Merged
merged 13 commits into from
Sep 25, 2024
Merged

Feature/smilescreens #236

merged 13 commits into from
Sep 25, 2024

Conversation

JNdhlovu
Copy link
Contributor

Story: https://app.shortcut.com/smileid/story/13199/allow-wrappers-sdks-to-capture-face-images-separately-v10-react-vs-flutter

Summary

Modify access for need utils in the wrappers

Known Issues

N/A

Test Instructions

Everything should work as per normal no functional changes

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.

@JNdhlovu JNdhlovu requested a review from a team as a code owner September 24, 2024 11:45
Copy link

github-actions bot commented Sep 24, 2024

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/Networking/Models/v2/Metadata.swift#L174 - Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

⚠️

Sources/SmileID/Classes/Networking/Models/v2/Metadata.swift#L183 - Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)

⚠️

Sources/SmileID/Classes/SmileID.swift#L31 - Line should be 120 characters or less: currently 124 characters (line_length)

⚠️

Sources/SmileID/Classes/SmileID.swift#L158 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)

⚠️

Sources/SmileID/Classes/SmileID.swift#L183 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

⚠️

Sources/SmileID/Classes/SmileID.swift#L210 - Collection literals should not have trailing commas. (trailing_comma)

Generated by 🚫 Danger Swift against 9063e52

Copy link
Contributor

@tobitech tobitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

public static func `default`() -> Metadata {
Metadata(items: [
.sdk,
.sdkVersion,
.clientIP,
.fingerprint,
.deviceModel,
.deviceOS
.deviceOS,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Collection literals should not have trailing commas. (trailing_comma)

@JNdhlovu JNdhlovu merged commit b41acab into main Sep 25, 2024
2 of 3 checks passed
@JNdhlovu JNdhlovu deleted the feature/smilescreens branch September 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants