Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/smilescreens #239

Merged
merged 15 commits into from
Oct 2, 2024
Merged

Feature/smilescreens #239

merged 15 commits into from
Oct 2, 2024

Conversation

JNdhlovu
Copy link
Contributor

@JNdhlovu JNdhlovu commented Oct 1, 2024

Story: https://app.shortcut.com/smileid/story/13199/allow-wrappers-sdks-to-capture-face-images-separately-v10-react-vs-flutter

Summary

Selfie capture UI without the whole flow and optionally can show or hide the confirmation dialog before returning the file paths

Known Issues

Need to release #231 for iOS to be complete

Test Instructions

There is a new button with title Selfie Capture click and capture should return the file paths on both android and iOS

  1. Show attrition
  2. Show confirmation
  3. File paths should match the provided job id

Screenshot

@JNdhlovu JNdhlovu requested a review from a team as a code owner October 1, 2024 22:13
Copy link

github-actions bot commented Oct 1, 2024

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.

Generated by 🚫 Danger Swift against e015f6d

Copy link
Contributor

@tobitech tobitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JNdhlovu JNdhlovu merged commit eb65efc into main Oct 2, 2024
3 checks passed
@JNdhlovu JNdhlovu deleted the feature/smilescreens branch October 2, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants