Refactor Selfie Submission and New Submission UX #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Example/Podfile.lock # Example/SmileID.xcodeproj/project.pbxproj # SmileID.xcodeproj/project.pbxproj # Sources/SmileID/Classes/DocumentVerification/Model/DocumentCaptureViewModel.swift # Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift
# Conflicts: # Example/SmileID.xcodeproj/project.pbxproj
…should be displayed with instructions after delay.
# Conflicts: # Example/Podfile.lock
# Conflicts: # Example/Podfile.lock
# Conflicts: # Sources/SmileID/Classes/SelfieCapture/View/FaceBoundingArea.swift # Sources/SmileID/Classes/SelfieCapture/View/SelfieCaptureScreenV2.swift # Sources/SmileID/Classes/SelfieCapture/View/UserInstructionsView.swift
…tor, face validator and selfie view model. some code formatting.
…ght capture instruction.
…layout guide positioning.
…w model. add the right title to processing screen.
# Conflicts: # Example/SmileID.xcodeproj/project.pbxproj # Sources/SmileID/Classes/FaceDetector/FaceDetectorV2.swift # Sources/SmileID/Classes/FaceDetector/FaceValidator.swift # Sources/SmileID/Classes/FaceDetector/LivenessCheckManager.swift # Sources/SmileID/Classes/SelfieCapture/SelfieCaptureInstruction.swift # Sources/SmileID/Classes/SelfieCapture/SelfieViewModelAction.swift # Sources/SmileID/Classes/SelfieCapture/SelfieViewModelV2.swift # Sources/SmileID/Classes/SelfieCapture/View/FaceBoundingArea.swift # Sources/SmileID/Classes/SelfieCapture/View/SelfieCaptureScreenV2.swift # Sources/SmileID/Classes/SelfieCapture/View/SelfieProcessingView.swift # Sources/SmileID/Resources/Localization/en.lproj/Localizable.strings
JNdhlovu
requested changes
Oct 22, 2024
| @@ -17,7 +17,7 @@ final class FaceValidator { | |||
| // MARK: Constants | |||
| private let selfieQualityThreshold: Float = 0.5 | |||
| private let luminanceThreshold: ClosedRange<Int> = 80...200 | |||
| private let faceBoundsMultiplier: CGFloat = 1.2 | |||
| private let faceBoundsMultiplier: CGFloat = 1.5 | |||
There was a problem hiding this comment.
I think this may need review provided screenshot on slack
| case .inProgress: | ||
| ZStack(alignment: .center) { | ||
| Circle() | ||
| .fill(Color(hex: "060606")) |
There was a problem hiding this comment.
@tobitech can we make this a themeable color?
# Conflicts: # Example/Podfile.lock # Example/SmileID/Home/HomeView.swift # Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift
# Conflicts: # Example/Podfile.lock
# Conflicts: # Example/Podfile.lock # Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift
JNdhlovu
approved these changes
Nov 6, 2024
| } | ||
| guard taskTimer == nil else { return } | ||
| DispatchQueue.main.async { | ||
| self.taskTimer = Timer.scheduledTimer( |
There was a problem hiding this comment.
nit on weak self per other PR
| @@ -221,6 +255,13 @@ extension SelfieViewModelV2 { | |||
| print(error.localizedDescription) | |||
There was a problem hiding this comment.
not a new change but maybe we could make this debugprint?
There was a problem hiding this comment.
Thanks for pointing that out. I think we'd have to use a proper logging framework like OSLog eventually.
|
Closing this PR in favour of the updated design implemented here #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/13453/
Summary
Known Issues
N/A
Test Instructions
N/A.
Screenshot