Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Retry After Previous Offline State. #247

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Conversation

tobitech
Copy link
Contributor

@tobitech tobitech commented Oct 23, 2024

Story: https://app.shortcut.com/smileid/story/13656/

Summary

  • Refactor submission for BiometricKYC Jobs
  • Fix how offline job failure scenario is handled.

Known Issues

N/A.

Test Instructions

The bug here is the unresponsiveness of the retry action when trying to submit a biometric job that initially failed due to internet connection:
So when you start a biometric KYC job, before submitting, you turn off your internet
Then you get a failed pop up for failure due to internet connection
Then you turn on internet back on and click retry
If everything goes well the job should be submitted

Screenshot

N/A

@tobitech tobitech self-assigned this Oct 23, 2024
@tobitech tobitech requested a review from a team as a code owner October 23, 2024 21:55
Copy link

github-actions bot commented Oct 23, 2024

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/BiometricKYC/OrchestratedBiometricKycViewModel.swift#L173 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

⚠️

Sources/SmileID/Classes/DocumentVerification/Model/OrchestratedDocumentVerificationViewModel.swift#L112 - Function should have complexity 10 or less: currently complexity equals 14 (cyclomatic_complexity)

⚠️

Sources/SmileID/Classes/DocumentVerification/Model/OrchestratedDocumentVerificationViewModel.swift#L200 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

⚠️

Sources/SmileID/Classes/DocumentVerification/Model/OrchestratedDocumentVerificationViewModel.swift#L324 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

⚠️

Sources/SmileID/Classes/DocumentVerification/Model/OrchestratedDocumentVerificationViewModel.swift#L350 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

⚠️

Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift#L194 - TODOs should be resolved (Use mouth deformation as an al...). (todo)

Generated by 🚫 Danger Swift against 66533cf

@tobitech tobitech merged commit 78fa022 into main Oct 25, 2024
3 checks passed
@tobitech tobitech deleted the fix-network-offline-retry branch October 25, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants