Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump version to 10.2.15 #248

Merged
merged 2 commits into from
Oct 25, 2024
Merged

chore: bump version to 10.2.15 #248

merged 2 commits into from
Oct 25, 2024

Conversation

tobitech
Copy link
Contributor

Summary

Prepare for release - 10.2.14

Known Issues

N/A.

Test Instructions

N/A.

Screenshot

N/A.

@tobitech tobitech self-assigned this Oct 25, 2024
@tobitech tobitech requested a review from a team as a code owner October 25, 2024 09:46
@github-actions GitHub Actions
Copy link

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/SmileID.swift#L31 - Line should be 120 characters or less: currently 124 characters (line_length)
⚠️

Sources/SmileID/Classes/SmileID.swift#L158 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)
⚠️

Sources/SmileID/Classes/SmileID.swift#L183 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)
⚠️

Sources/SmileID/Classes/SmileID.swift#L210 - Collection literals should not have trailing commas. (trailing_comma)

Generated by 🚫 Danger Swift against c1ebdd3

beastawakens
beastawakens approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@beastawakens beastawakens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobitech tobitech merged commit dbe958d into main Oct 25, 2024
3 checks passed
@tobitech tobitech deleted the release/10.2.15 branch October 25, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumaallan jumaallan jumaallan approved these changes

@beastawakens beastawakens beastawakens approved these changes

Assignees

@tobitech tobitech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobitech @beastawakens @jumaallan