Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clear files on retry and on start capture #251

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

JNdhlovu
Copy link
Contributor

@JNdhlovu JNdhlovu commented Nov 6, 2024

Story: https://app.shortcut.com/smileid/story/14220/fix-retry-with-multiple-liveness-images-on-ios-android

Summary

Fix Retry with multiple liveness images on IOS & Android

Known Issues

N/A

Test Instructions

Capture a job then instead of submission retry and capture then submit, the number of liveness files should stay the same as the constant for liveness images limit

Screenshot

N/A

@JNdhlovu JNdhlovu requested a review from a team as a code owner November 6, 2024 13:42
Copy link

github-actions bot commented Nov 6, 2024

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift#L195 - TODOs should be resolved (Use mouth deformation as an al...). (todo)

⚠️

Sources/SmileID/Classes/SmileID.swift#L31 - Line should be 120 characters or less: currently 124 characters (line_length)

⚠️

Sources/SmileID/Classes/SmileID.swift#L158 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)

⚠️

Sources/SmileID/Classes/SmileID.swift#L183 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

⚠️

Sources/SmileID/Classes/SmileID.swift#L210 - Collection literals should not have trailing commas. (trailing_comma)

Generated by 🚫 Danger Swift against c0e2dbd

@JNdhlovu JNdhlovu merged commit c61c844 into main Nov 7, 2024
3 checks passed
@JNdhlovu JNdhlovu deleted the bugfix/livenessimageslimit branch November 7, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants