feat: update changelog #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Titlefeat: update changelog User descriptionStory: https://app.shortcut.com/smileid/story/xxx SummarySister android PR smileidentity/android#489 Known IssuesN/A Test Instructions
ScreenshotN/A PR TypeEnhancement DescriptionThis PR introduces a new feature that allows skipping API submission to SmileID:
Changes walkthrough 📝
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Generated by 🚫 Danger Swift against bd95e9a |
PR Code Suggestions ✨Explore these optional code suggestions:
|
tobitech
approved these changes
Nov 18, 2024
tobitech
added a commit
that referenced
this pull request
Dec 10, 2024
* decouple selfieviewmodel from livenesscheckmanager * improve object references so to prevent retain cycles. * write custom encoding function for failure reason, replace forced failure with failure reason enum. append failure reason data to multipart form request body. * check that submission task is nil before assigning it. * remove unnecessary comment * feat: update changelog (#254) * feat: update changelog * chore: lint fix * fix wrong version set for fingerprintjs package and dependency name causing spm not to resolve (#257) * added autoassign to workflow (#259) * added autoassign to workflow * added autoassign to workflow/fix * pod install * add beta tag to strict mode products. add a cancel toolbar button to all product screens. remove cancel button from liveness instructions screen. * use a different multiplier for checking face bounds for selfie and liveness capture hide liveness progress if face is not valid. * bump build number and add haptic feedback to selfie capture. * reduce luminance threshold lowerbound * reduce luminace threshold lower bound * introduce a function to flip the selfie image for preview during submission. * reduce head turn thresholds * remove brightness check from selfie capture v2 * adjust screen brightness for selfie capture screen v2 * Chore(deps): bump rexml from 3.3.6 to 3.3.9 (#249) Bumps [rexml](https://github.com/ruby/rexml) from 3.3.6 to 3.3.9. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.6...v3.3.9) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JNdhlovu <[email protected]> Co-authored-by: Tobi Omotayo <[email protected]> * bump version number. * replace selfie quality check with vision face quality in face detector and face validator. * reset the submission task when there is a response or error. * improve publisher reference for legacy selfie view model. * use weak reference in legacy selfie view model to prevent retain cycle. * introduce a backport of StateObject into sdk helpers * disable idle timer when capturing selfie and enable it back when dismissed. * use a backport of stateobject in selfie capture screen. * bump build number. * restore brightness check * check orientation before analyzing camera frames. * add a did cancel delegate method to selfie result delegate. * Chore(deps): bump slackapi/slack-github-action (#260) * add property to set camera name in camera manager. implement fallback for pre-ios 15 devices. add didCancel endpoint to smart selfie result delegate. * use uniqueID for cameraname. add a delay when capturing random liveness images during timeout. * import new typeface DMSans and define a model to manage its fonts and styles. * add face not within frame case to face bounds state. * remove overlay from face bounding area. introduce new version of animations. * code formatting. * correct instructions typo. * change new smart selfie products name. disable lint checks for backport files. code formatting. * rename smart selfie v2 to enhanced * pod install. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: JNdhlovu <[email protected]> Co-authored-by: Davina Anthony <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jumaallan
added a commit
that referenced
this pull request
Dec 13, 2024
* New Smart Selfie Capture UI (#202) * implement design for selfie capture camera frame. * add lottie animation, product cells for selfie enrollment and selfie authentication with strict mode. * control visibility of smile emblem with showAttribution flag * make selfie frame border themable. * Selfie Quality Check With CoreML Model (#206) * implement design for selfie capture camera frame. * add lottie animation, product cells for selfie enrollment and selfie authentication with strict mode. * update new selfie view model with existing implementation * add some image utility functions, import selfie quality model and add selfie quality check to the image buffer from camera feed. * some code formatting * more code formatting * compile coreml model to generate .mlmodelc file. * automatically generate the model class file. * remove uncompiled model file. * disable lint from generated file. * make a separate class that will handle all the image processing and classification tasks for selfie quality check. * add some documentation and code formatting * fix issue with crop to face function. * Replace the selfie quality model with a new version that takes an image as input. * remove call to check selfie quality in the v2 view model. * disable linting for model generated file. * code formattting. * remove resources folder and the lottie file. * code formatting. * move model image cropping size info to a constant. * run pod install * Introduce new versions for FaceDetector, SelfieViewModel classes and Liveness Check Manager. (#224) * implement design for selfie capture camera frame. * add lottie animation, product cells for selfie enrollment and selfie authentication with strict mode. * update new selfie view model with existing implementation * add some image utility functions, import selfie quality model and add selfie quality check to the image buffer from camera feed. * some code formatting * more code formatting * compile coreml model to generate .mlmodelc file. * automatically generate the model class file. * remove uncompiled model file. * disable lint from generated file. * make a separate class that will handle all the image processing and classification tasks for selfie quality check. * add some documentation and code formatting * fix issue with crop to face function. * introduce a new version for facedetector class and new debug design for selfie capture screen. also refactor state management and action handling for the selfie view model v2 * rename preview view to camera view controller * hook up new face detector class to the new selfie view model. * integrate the new model that takes an image input and also display the outputs in the debug view in real time. * remove lottie resources. code formatting. * Add new debug views and and also use av preview layer to calculate the bounding box * Fix issue with face bounding box. implement face size and positioning within the frame. * add instructions view to the selfie capture screen. * add image capture to the selfie view model. * Add a view to show captured images: selfie and liveness. * add active liveness manager class and move updating directive to the view model. * some clean up * remove print statements from facedetectorv2 * move face geometry check for active liveness into the liveness manager * refactor how current task is assigned and how directive for liveness task is displayed * update criteria for passing the liveness checks * fix the length of the captured image view * code formatting * add some documentation to liveness check manager class * more docs * run pod install * folder structure changes. * code formatting. * import UIkit inside Imageclassifier. * add the ML folder group into the right target. * some layout changes. * update the bundle for the generated ml model class. * move initialisation for the image classifier into the init function so that it's done only once * run pod install * run pod install. * Liveness Capture Instructions Screen (#229) * implement design for selfie capture camera frame. * add lottie animation, product cells for selfie enrollment and selfie authentication with strict mode. * update new selfie view model with existing implementation * add some image utility functions, import selfie quality model and add selfie quality check to the image buffer from camera feed. * some code formatting * more code formatting * compile coreml model to generate .mlmodelc file. * automatically generate the model class file. * remove uncompiled model file. * disable lint from generated file. * make a separate class that will handle all the image processing and classification tasks for selfie quality check. * add some documentation and code formatting * fix issue with crop to face function. * introduce a new version for facedetector class and new debug design for selfie capture screen. also refactor state management and action handling for the selfie view model v2 * rename preview view to camera view controller * hook up new face detector class to the new selfie view model. * integrate the new model that takes an image input and also display the outputs in the debug view in real time. * remove lottie resources. code formatting. * Add new debug views and and also use av preview layer to calculate the bounding box * Fix issue with face bounding box. implement face size and positioning within the frame. * add instructions view to the selfie capture screen. * add image capture to the selfie view model. * Add a view to show captured images: selfie and liveness. * add active liveness manager class and move updating directive to the view model. * some clean up * remove print statements from facedetectorv2 * move face geometry check for active liveness into the liveness manager * refactor how current task is assigned and how directive for liveness task is displayed * update criteria for passing the liveness checks * fix the length of the captured image view * code formatting * add some documentation to liveness check manager class * more docs * run pod install * folder structure changes. * code formatting. * import UIkit inside Imageclassifier. * add some views for new selfie design * create a folder group for lottie files in the resources folder and add a new lottie file. * add lottie animation to liveness instructions screen. * rename selfie capture instructions view to liveness capture * Add liveness guides view with the 3 progress arcs * restore lottie view * import the liveness guide lottie file into resources. * Remove comments * run pod install. * run pod install * New Camera UI (#235) * improve code and file structure * add the liveness guides * add some config values to liveness guides view. * change lottie animation frame * run pod install * setup animation progress time for the liiveness guide lottie animation. * refactor the components of liveness guides view. * run pod install. * Connect ViewModel to New UI and Refactoring (#237) * improve code and file structure * add the liveness guides * add some config values to liveness guides view. * change lottie animation frame * run pod install * setup animation progress time for the liiveness guide lottie animation. * fix homeview fore each warnings. * connect face bounds detection to the the indicator. * add throttling to camera feed. * use full screen cover to present home screen products. * control progress arc visibility based on progress. * add a dummy submit function. * setup timers. * add animation to the progress fill arcs. * refactor the components of liveness guides view. * setup delay timer and introduce state for the current animation that should be displayed with instructions after delay. * update arc shape init * add new lottie files. define a guide animation enum to hold the animation details. * some refactoring. * create a validator class for the face observation data. * refactor buffer image processing and communication between face detector, face validator and selfie view model. some code formatting. * remove some debug views. some refactoring and improvements. * make capture instruction strings localizable * introduce current liveness task into the face validator to set the right capture instruction. * fix cropping for selfie quality check. * show or hide the circular ring and the liveness guides based on whether face is within bounds. * add processing view to view captured images. * reset animation as user is completing liveness checks * localise instruction. use appropriate error for face not found. * refactor image conversion for use in brightness and selfie quality checks. * replace ObservedObject with StateObject in HomeView to prevent multiple initialising. * run pod install * Box Oval Interface for Selfie Capture Screen (#250) * improve code and file structure * add the liveness guides * add some config values to liveness guides view. * change lottie animation frame * run pod install * setup animation progress time for the liiveness guide lottie animation. * fix homeview fore each warnings. * connect face bounds detection to the the indicator. * add throttling to camera feed. * use full screen cover to present home screen products. * control progress arc visibility based on progress. * add a dummy submit function. * setup timers. * add animation to the progress fill arcs. * refactor the components of liveness guides view. * setup delay timer and introduce state for the current animation that should be displayed with instructions after delay. * update arc shape init * add new lottie files. define a guide animation enum to hold the animation details. * some refactoring. * create a validator class for the face observation data. * refactor buffer image processing and communication between face detector, face validator and selfie view model. some code formatting. * remove some debug views. some refactoring and improvements. * make capture instruction strings localizable * introduce current liveness task into the face validator to set the right capture instruction. * fix cropping for selfie quality check. * show or hide the circular ring and the liveness guides based on whether face is within bounds. * add processing view to view captured images. * reset animation as user is completing liveness checks * inject current liveness task into liveness guide to control which progress is showing. update reset delay timer on main thread. use appropriate error for face detection during cropping. * processing screen layout. introduce a backport of stateobject. * run pod install to import missing lottie files. * present selfie capture flow in navigation view, programmatically navigate to processing view based on capture status. add a circular progress view with a loader image for the selfie processing view. * refactor view appear setup and reset selfie capture state variables * import submit method from selfie viewmodel. * extract submit selfie functionality into a new class to manage the submission processes. * some refactoring * move backport and stateobject to helper folder. * code formatting. * restore threshold value * replace ObservedObject with StateObject in HomeView so that it's initialised once. * use proxy size instead of frame for window size calculation and face layout guide positioning. * remove stateobject backport * use a delegate to communicate selfie submission updates to selfie view model. add the right title to processing screen. * update processing changes on main thread. * inject failure reason into the api call for submitting selfie * rename selfie submission manager * reset the threshold for timeout for liveness check. * remove presentation mode variable. * introduce an environment key to manage dismissing of the selfie capture flow. * improve error handling of selfie capture. * localise strings. * code formatting. * pod install * make loader background color themeable. * run pod install. * fix missing files and build errors. * redesign selfie capture screen to use box and oval for camera area and face bounding area * add a view to preview selfie image, also add an actions view. * redesign the the progress arcs for active liveness. * improvements to validating face bounding box. add a frame to selfie preview image. * remove processing view, add a view state to control visibility of different items based on capture state. * adjust face size and position evaluation. fix layout for attribution and retry button. * change active liveness progress colours * code formatting. * update faceboundmultiplier constant. * refactor task timer. * improve submission handling. * Face Validator Tests (#252) * add test for valid face. * add more test cases for face validator class. * refactor out common functionality for reusability in the validator tests. * run pod install * run pod install. * Liveness Timeout Images (#253) * decouple selfieviewmodel from livenesscheckmanager * improve object references so to prevent retain cycles. * write custom encoding function for failure reason, replace forced failure with failure reason enum. append failure reason data to multipart form request body. * check that submission task is nil before assigning it. * remove unnecessary comment * feat: update changelog (#254) * feat: update changelog * chore: lint fix * fix wrong version set for fingerprintjs package and dependency name causing spm not to resolve (#257) * added autoassign to workflow (#259) * added autoassign to workflow * added autoassign to workflow/fix * pod install * add beta tag to strict mode products. add a cancel toolbar button to all product screens. remove cancel button from liveness instructions screen. * use a different multiplier for checking face bounds for selfie and liveness capture hide liveness progress if face is not valid. * bump build number and add haptic feedback to selfie capture. * reduce luminance threshold lowerbound * reduce luminace threshold lower bound * introduce a function to flip the selfie image for preview during submission. * reduce head turn thresholds * remove brightness check from selfie capture v2 * adjust screen brightness for selfie capture screen v2 * Chore(deps): bump rexml from 3.3.6 to 3.3.9 (#249) Bumps [rexml](https://github.com/ruby/rexml) from 3.3.6 to 3.3.9. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.6...v3.3.9) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JNdhlovu <[email protected]> Co-authored-by: Tobi Omotayo <[email protected]> * bump version number. * replace selfie quality check with vision face quality in face detector and face validator. * reset the submission task when there is a response or error. * improve publisher reference for legacy selfie view model. * use weak reference in legacy selfie view model to prevent retain cycle. * introduce a backport of StateObject into sdk helpers * disable idle timer when capturing selfie and enable it back when dismissed. * use a backport of stateobject in selfie capture screen. * bump build number. * restore brightness check * check orientation before analyzing camera frames. * add a did cancel delegate method to selfie result delegate. * Chore(deps): bump slackapi/slack-github-action (#260) * add property to set camera name in camera manager. implement fallback for pre-ios 15 devices. add didCancel endpoint to smart selfie result delegate. * use uniqueID for cameraname. add a delay when capturing random liveness images during timeout. * import new typeface DMSans and define a model to manage its fonts and styles. * add face not within frame case to face bounds state. * remove overlay from face bounding area. introduce new version of animations. * code formatting. * correct instructions typo. * change new smart selfie products name. disable lint checks for backport files. code formatting. * rename smart selfie v2 to enhanced * pod install. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: JNdhlovu <[email protected]> Co-authored-by: Davina Anthony <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix UserID Refresh for New Jobs (#262) * set the right flag for isEnroll in orchestrated enhanced selfie capture screen. update the location of selfie and livenessimages when submission fails. * grab last selfie enrollment userid from pasteboard, use new generated user id for selfie authentication * fix the layout issues with biometric kyc and enhanced kyc country picker. * bump version number. remove comments. * add encryption compliance key and value for non exempt encryption * Device Motion Orientation (#263) * code formatting. * revert max pitch threshold * correct instructions copy * use device motion to determine device orientation and fall back to unlocked device orientation if device motion is not available. * code formatting * update to new lottie animation designs. * Fix Selfie and Liveness Image Sizes, Fix Layout for Small Screen Devices (#266) * Fixed Missing Document Type (#264) * added missing document type in document jobs * Update CHANGELOG.md * add new submission status icons for success and failed states. * remove setting initial value for user instruction. * handle multiple faces detected and throw an error * change order of face validator so that luminance is checked before head position. * reduce the stroke size of the face in bounds indicator. * remove done button and hide cancel button if submission was successful. * use new status icons in status view. * add a placeholder for api error 2214 * update selfie actions view parameters * restore camera manager to have accessible initializer. add camera session size preset for selfie capture image * code formatting and set line limit of 2 to user instructions title. * change capture screen layout to accommodate small screen devices. remove cancel delegate method from selfie result. * dismiss the selfie capture when submission is successful. --------- Co-authored-by: Juma Allan <[email protected]> * Adding Active Liveness Metadata (#265) * added active liveness metadata * added headpose metadata * updated camera name metadata * updated liveness type * fix the camera info collection. * code formatting --------- Co-authored-by: Tobi Omotayo <[email protected]> * update changelog. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: JNdhlovu <[email protected]> Co-authored-by: Davina Anthony <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Juma Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/xxx
Summary
Sister android PR smileidentity/android#489
Add skip api submission to allow for captures without submission to the SmileID api and will return file paths
Known Issues
N/A
Test Instructions
Screenshot
N/A