Adding Active Liveness Metadata

[jumaallan]

Story: https://app.shortcut.com/smileid/story/xxx

Summary

A few sentences/bullet points about the changes

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.

[github-actions]

	Warnings
⚠️	The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.

Generated by 🚫 Danger Swift against 8c97d30

[prfectionist]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Hardcoded Version The active liveness version is hardcoded to '1.0.0'. Consider making this configurable or derived from a central version source to avoid inconsistencies when version changes are needed. Limited Liveness Type The code only sets 'headPose' as the liveness type, but the enum also supports 'smile'. Consider if this is intentional or if the type should be determined dynamically based on the actual liveness check being performed.

[prfectionist]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Use dynamic values instead of hardcoded enum cases to reflect actual runtime state The hardcoded LivenessType.headPose might not reflect the actual liveness type being used. Consider passing the actual liveness type as a parameter. Sources/SmileID/Classes/SelfieCapture/EnhancedSmartSelfieViewModel.swift [476] -localMetadata.addMetadata(Metadatum.ActiveLivenessType(livenessType: LivenessType.headPose)) +localMetadata.addMetadata(Metadatum.ActiveLivenessType(livenessType: currentLivenessType)) Suggestion importance[1-10]: 8 Why: Hardcoding LivenessType.headPose could lead to incorrect metadata if different liveness types are used at runtime. Using the actual liveness type would ensure accurate tracking and prevent potential bugs.	8
Maintainability	Avoid hardcoding version strings to make version updates more maintainable Consider making the active liveness version a configurable value rather than hardcoding "1.0.0", as this will need to be updated with each version change. Sources/SmileID/Classes/Networking/Models/v2/Metadata.swift [54] -public static let activeLivenessVersion = Metadatum(name: "active_liveness_version", value: "1.0.0") +public static let activeLivenessVersion = Metadatum(name: "active_liveness_version", value: SmileID.activeLivenessVersion) Suggestion importance[1-10]: 7 Why: Hardcoding version strings makes updates error-prone and requires code changes. Using a configurable value would improve maintainability and reduce the risk of outdated version information.	7
Enhancement	Remove unnecessary code by eliminating redundant decoder implementations The ActiveLivenessType class could be simplified by removing the redundant decoder implementation since it doesn't add any functionality beyond the superclass. Sources/SmileID/Classes/Networking/Models/v2/Metadata.swift [60-68] public class ActiveLivenessType: Metadatum { public init(livenessType: LivenessType) { super.init(name: "active_liveness_type", value: livenessType.rawValue) } - - public required init(from decoder: Decoder) throws { - try super.init(from: decoder) - } } Suggestion importance[1-10]: 4 Why: While the suggestion is correct about the decoder implementation being redundant, removing it has minimal impact on functionality or performance. It's a minor code cleanup improvement.	4

[robin-ankele]

Look fine to me. Thanks @jumaallan

[robin-ankele]

Actually, @jumaallan can you also add the liveness type smile to the legacy SelfieViewModel?

[github-actions]

• ⚠️ TODOs should be resolved (Use mouth deformation as an al...). (todo)