New Smart Selfie Capture

[tobitech]

Stories:
https://app.shortcut.com/smileid/story/13453/improve-user-experience-of-new-active-liveness-screens-v10-ios
https://app.shortcut.com/smileid/story/13080/add-active-liveness-smartselfie-v2-ios

Summary

This includes all the tasks for the implementation for new Enhanced Selfie Enrollment and Authentication.

Known Issues

N/A.

Test Instructions

N/A.

Screenshot

N/A

[github-actions]

	Warnings
⚠️	The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️	Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift#L229 - TODOs should be resolved (Use mouth deformation as an al...). (todo)
⚠️	Sources/SmileID/Classes/SelfieCapture/View/FaceShapedProgressIndicator.swift#L14 - TODOs should be resolved (Make this fill from bottom to ...). (todo)
⚠️	Sources/SmileID/Classes/SmileID.swift#L159 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)
⚠️	Sources/SmileID/Classes/SmileID.swift#L186 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

Generated by 🚫 Danger Swift against 9f24319

[prfectionist]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Memory Management Several closures capturing self without weak references could lead to retain cycles. Review memory management patterns. Error Handling The multipart request data creation has complex error handling paths that should be reviewed for edge cases and proper error propagation. Thread Safety Camera session configuration involves multiple queues and async operations. Review thread safety and synchronization.

[prfectionist]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible bug	Safe handling of optional values prevents runtime crashes The force unwrapping of imageBufferValue could crash if the MLFeatureValue creation fails. Consider using optional binding. Sources/SmileID/Classes/FaceDetector/SelfieQualityDetector.swift [36] -self.init(conv2d_193_input: try MLFeatureValue(cgImage: conv2d_193_input, pixelsWide: 120, pixelsHigh: 120, pixelFormatType: kCVPixelFormatType_32ARGB, options: nil).imageBufferValue!) +guard let buffer = try MLFeatureValue(cgImage: conv2d_193_input, pixelsWide: 120, pixelsHigh: 120, pixelFormatType: kCVPixelFormatType_32ARGB, options: nil).imageBufferValue else { + throw NSError(domain: "SelfieQualityDetector", code: -1, userInfo: [NSLocalizedDescriptionKey: "Failed to create image buffer"]) +} +self.init(conv2d_193_input: buffer) Suggestion importance[1-10]: 9 Why: The suggestion eliminates a force unwrap that could cause runtime crashes if MLFeatureValue creation fails. The proposed guard-let pattern with proper error handling is significantly safer.	9
	Using running average prevents potential numeric overflow in calculations The brightness calculation could overflow for large images since it accumulates values in a Double before dividing. Consider using running average instead. Sources/SmileID/Classes/FaceDetector/EnhancedFaceDetector.swift [200-205] for index in stride(from: 0, to: dataLength, by: bytesPerPixel) { let red = dataPointer[index] let green = dataPointer[index + 1] let blue = dataPointer[index + 2] - result += 0.299 * Double(red) + 0.587 * Double(green) + 0.114 * Double(blue) + result = result + (0.299 * Double(red) + 0.587 * Double(green) + 0.114 * Double(blue) - result) / Double(index/bytesPerPixel + 1) } Suggestion importance[1-10]: 7 Why: The suggestion prevents potential numeric overflow in brightness calculations for large images, which could lead to incorrect results or crashes. The running average approach is more numerically stable.	7
Possible issue	Use weak self references in closures to prevent retain cycles Consider using a weak reference to self in the Timer closure to prevent potential retain cycles. Sources/SmileID/Classes/SelfieCapture/EnhancedSmartSelfieViewModel.swift [239-249] Timer.scheduledTimer( timeInterval: 1, repeats: true -) { _ in +) { [weak self] _ in + guard let self = self else { return } self.elapsedGuideAnimationDelay += 1 if self.elapsedGuideAnimationDelay == self.guideAnimationDelayTime { self.showGuideAnimation = true self.stopGuideAnimationDelayTimer() } } Suggestion importance[1-10]: 8 Why: Strong reference to self in timer closure can create retain cycles, leading to memory leaks. Using weak self is a critical Swift best practice for memory management.	8
	Early validation of critical dependencies during initialization prevents runtime errors Consider using a guard statement to early return if selfieQualityModel is nil during initialization, rather than silently continuing with a nil model that will cause issues later. Sources/SmileID/Classes/FaceDetector/EnhancedFaceDetector.swift [39-42] -override init() { +override init() throws { super.init() - selfieQualityModel = createImageClassifier() + guard let model = createImageClassifier() else { + throw FaceDetectorError.unableToLoadSelfieModel + } + selfieQualityModel = model } Suggestion importance[1-10]: 8 Why: The suggestion addresses a critical issue where a nil model could cause runtime failures. Making the initializer throwing and validating the model early improves error handling and reliability.	8
	Add logging for cases where camera session preset configuration fails Consider adding error handling for the session preset configuration to handle cases where the desired preset cannot be set. Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift [85-87] if cameraManager.session.canSetSessionPreset(.vga640x480) { cameraManager.session.sessionPreset = .vga640x480 +} else { + print("Warning: Unable to set camera session preset to VGA resolution") } Suggestion importance[1-10]: 5 Why: The suggestion improves error handling by adding logging for configuration failures, making it easier to diagnose camera setup issues.	5
Best practice	Add guard statement to handle weak self unwrapping to prevent force unwrapping of optional self Use weak self in the sink closure for cameraManager.sampleBufferPublisher to prevent potential retain cycles. Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift [95-107] cameraManager.sampleBufferPublisher .merge(with: arKitFramePublisher) .throttle( for: 0.35, scheduler: DispatchQueue.global(qos: .userInitiated), latest: true ) .dropFirst(5) .compactMap { $0 } .sink { [weak self] imageBuffer in - self?.analyzeImage(image: imageBuffer) + guard let self else { return } + self.analyzeImage(image: imageBuffer) } .store(in: &subscribers) Suggestion importance[1-10]: 7 Why: The suggestion improves memory management and safety by properly handling weak self unwrapping, preventing potential retain cycles and crashes from force unwrapping.	7
	Improve error handling for IP address resolution failures Add error handling for the case when the IP address lookup fails instead of silently returning an empty string. Sources/SmileID/Classes/Networking/Models/v2/Metadata.swift [205-206] func getIPAddress(useIPv4: Bool) -> String { - var address: String = "" + var address: String = "unknown" Suggestion importance[1-10]: 4 Why: Using a default value of "unknown" instead of an empty string makes it clearer when IP address resolution fails, though the impact is relatively minor.	4
Enhancement	Add proper error handling for graphics context failures Consider adding error handling for the case when image flipping fails instead of returning nil silently. Sources/SmileID/Classes/SelfieCapture/EnhancedSmartSelfieViewModel.swift [313-315] guard let context = UIGraphicsGetCurrentContext() else { + handleError(SmileIDError.unknown("Failed to get graphics context for image flipping")) return nil } Suggestion importance[1-10]: 6 Why: Adding explicit error handling for graphics context failures improves error traceability and debugging capabilities, making the code more robust and maintainable.	6
	Improve error message clarity by providing more specific failure details Consider using a more descriptive error message when throwing the selfie capture failure error. Sources/SmileID/Classes/SelfieCapture/SelfieViewModel.swift [391-393] guard let selfieImage, livenessImages.count == numLivenessImages else { - throw SmileIDError.unknown("Selfie capture failed") + throw SmileIDError.unknown("Selfie capture failed: Missing selfie image or incorrect number of liveness images") } Suggestion importance[1-10]: 4 Why: Adding more descriptive error messages helps with debugging and troubleshooting, though it's a minor improvement that doesn't affect functionality.	4