Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 10.3.1 #270

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Release 10.3.1 #270

merged 1 commit into from
Dec 13, 2024

Conversation

jumaallan
Copy link
Member

Story: https://app.shortcut.com/smileid/story/xxx

Summary

A few sentences/bullet points about the changes

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.

@jumaallan jumaallan requested a review from a team as a code owner December 13, 2024 17:52
@prfectionist
Copy link

prfectionist bot commented Dec 13, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Mismatch
Verify that all version references are updated consistently and match the intended release version

@prfectionist
Copy link

prfectionist bot commented Dec 13, 2024

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Maintainability
Use string interpolation for version numbers to maintain consistency and reduce manual update errors

Consider using string interpolation for the tag version to ensure consistency with
the version number and avoid potential mismatches.

SmileID.podspec [3-8]

 s.version          = '10.3.1'
-s.source           = { :git => "https://github.com/smileidentity/ios.git", :tag => "v10.3.1" }
+s.source           = { :git => "https://github.com/smileidentity/ios.git", :tag => "v#{s.version}" }
Suggestion importance[1-10]: 7

Why: Using string interpolation for the version tag is a good practice to prevent version mismatch errors and reduce maintenance overhead when updating versions. This suggestion helps maintain consistency between the version number and git tag.

7

Copy link

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/SmileID.swift#L159 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)

⚠️

Sources/SmileID/Classes/SmileID.swift#L186 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

⚠️

Sources/SmileID/Classes/SmileID.swift#L324 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Sources/SmileID/Classes/SmileID.swift#L403 - Lines should not have trailing whitespace. (trailing_whitespace)

Generated by 🚫 Danger Swift against 5b2903b

@jumaallan jumaallan merged commit c623f7f into main Dec 13, 2024
4 checks passed
@jumaallan jumaallan deleted the prepare-10-3-1 branch December 13, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants