Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BVN networking models #80

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Add BVN networking models #80

merged 7 commits into from
Oct 18, 2023

Conversation

vanshg
Copy link
Contributor

@vanshg vanshg commented Oct 17, 2023

Story: https://app.shortcut.com/smileid/story/9097/add-bvn-enforced-consent-screens-to-the-v10-sdk-ios

Summary

Starts the work for adding BVN Consent. This adds the API calls and models

@vanshg vanshg requested a review from a team as a code owner October 17, 2023 23:49
@vanshg vanshg changed the base branch from feat/bvn-consent to main October 17, 2023 23:50
public let signature: String

enum CodingKeys: String, CodingKey {
case success = "success"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ String enum values can be omitted when they are equal to the enumcase name. (redundant_string_enum_value)


enum CodingKeys: String, CodingKey {
case success = "success"
case message = "message"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ String enum values can be omitted when they are equal to the enumcase name. (redundant_string_enum_value)

enum CodingKeys: String, CodingKey {
case success = "success"
case message = "message"
case timestamp = "timestamp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ String enum values can be omitted when they are equal to the enumcase name. (redundant_string_enum_value)

case success = "success"
case message = "message"
case timestamp = "timestamp"
case signature = "signature"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ String enum values can be omitted when they are equal to the enumcase name. (redundant_string_enum_value)

public let signature: String

enum CodingKeys: String, CodingKey {
case success = "success"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ String enum values can be omitted when they are equal to the enumcase name. (redundant_string_enum_value)


enum CodingKeys: String, CodingKey {
case success = "success"
case message = "message"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ String enum values can be omitted when they are equal to the enumcase name. (redundant_string_enum_value)

enum CodingKeys: String, CodingKey {
case success = "success"
case message = "message"
case timestamp = "timestamp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ String enum values can be omitted when they are equal to the enumcase name. (redundant_string_enum_value)

case success = "success"
case message = "message"
case timestamp = "timestamp"
case signature = "signature"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ String enum values can be omitted when they are equal to the enumcase name. (redundant_string_enum_value)

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.

Generated by 🚫 Danger Swift against d6db2d2

@vanshg vanshg merged commit a7fae81 into main Oct 18, 2023
3 checks passed
@vanshg vanshg deleted the feat/bvn-consent-networking branch October 18, 2023 23:36
JNdhlovu pushed a commit that referenced this pull request Jan 24, 2024
* Remove dead code

* Bump build number

* Add BVN networking models

* Update CHANGELOG

* leave the beta10 notes alone

* Bump build number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants