Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save SmartSelfie Enrollment userId on job completion #83

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

vanshg
Copy link
Contributor

@vanshg vanshg commented Oct 19, 2023

Summary

Since the SmartSelfie Enroll and Auth jobs share the same delegate and since the inital job result is still processing, we can't tell in the delegate what the job type is. This makes a change to define a separate delegate for enroll, so that we can save the userId used for enrollment and pre-populate the smartselfie auth user ID text field with it

@vanshg vanshg requested a review from a team as a code owner October 19, 2023 21:12
@github-actions
Copy link

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Example/SmileID/HomeView.swift#L31 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

⚠️

Example/SmileID/HomeView.swift#L31 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

⚠️

Example/SmileID/HomeView.swift#L31 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

⚠️

Example/SmileID/HomeView.swift#L31 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

⚠️

Example/SmileID/HomeView.swift#L150 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

⚠️

Example/SmileID/HomeView.swift#L150 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

⚠️

Example/SmileID/HomeView.swift#L150 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

⚠️

Example/SmileID/HomeView.swift#L178 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

⚠️

Example/SmileID/HomeView.swift#L178 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

⚠️

Example/SmileID/HomeView.swift#L178 - Closure parameters should be on the same line as opening brace. (closure_parameter_position)

Generated by 🚫 Danger Swift against 7bbcec0

@vanshg vanshg merged commit 19035f8 into main Oct 24, 2023
3 checks passed
@vanshg vanshg deleted the fix/smartselfie-classification branch October 24, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants