Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ID Info entry when consent required #94

Closed
wants to merge 2 commits into from
Closed

Conversation

vanshg
Copy link
Contributor

@vanshg vanshg commented Nov 2, 2023

Summary

If an IdInfo is passed in to Biometric KYC, but consent is required, we ignore the IdInfo passed as input and ask for the ID information again ouselves, per legal requirements

@vanshg vanshg requested a review from a team as a code owner November 2, 2023 22:41
@@ -124,6 +135,23 @@ internal class OrchestratedBiometricKycViewModel: ObservableObject, SelfieImageC
}

func onConsentGranted(country: String, idType: String, requiredFields: [RequiredField]) {
if idInfo != nil {
// Proactive explanation for partners so that this situation can be avoided
print("Consent was required, so we will ignore the passed in idInfo. Inputs will be asked from the user again.")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Line should be 120 characters or less: currently 124 characters (line_length)

Copy link

github-actions bot commented Nov 2, 2023

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.

Generated by 🚫 Danger Swift against 024820d

@vanshg
Copy link
Contributor Author

vanshg commented Nov 15, 2023

Closing this, as we will not be taking this approach

@vanshg vanshg closed this Nov 15, 2023
@vanshg vanshg deleted the enforced-consent branch November 15, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants