Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM compatibility #96

Merged
merged 3 commits into from
Nov 14, 2023
Merged

SPM compatibility #96

merged 3 commits into from
Nov 14, 2023

Conversation

JNdhlovu
Copy link
Contributor

SPM compatibility

Summary

  • Added missing imports it seems cocoapods can infer some types without imports but SPM needs those explicitly declared
  • Changed SPM resource bundling from copy to process

Known Issues

None

Test Instructions

The SDK should work as normal if you follow https://developer.apple.com/documentation/xcode/adding-package-dependencies-to-your-app

@JNdhlovu JNdhlovu requested a review from a team as a code owner November 14, 2023 10:04
Copy link

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.

Generated by 🚫 Danger Swift against a55fb14

@JNdhlovu JNdhlovu merged commit 1e7596d into main Nov 14, 2023
3 checks passed
@JNdhlovu JNdhlovu deleted the feature/spm branch November 14, 2023 10:51
@vanshg
Copy link
Contributor

vanshg commented Nov 15, 2023

As we discussed, it would be great if we could build with SPM as part of our build process to ensure this doesn't break again in the future

JNdhlovu added a commit that referenced this pull request Jan 24, 2024
* feat: add foundation imports

* feat: add foundation imports

* feat: add foundation imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants