Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Extras on JobTypes #97

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Pass Extras on JobTypes #97

merged 2 commits into from
Nov 14, 2023

Conversation

jumaallan
Copy link
Member

Story: https://app.shortcut.com/smileid/story/xxx

Summary

Pass Extras on JobTypes

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.

@jumaallan jumaallan requested a review from a team as a code owner November 14, 2023 14:38
Copy link

github-actions bot commented Nov 14, 2023

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/DocumentVerification/Model/OrchestratedDocumentVerificationViewModel.swift#L202 - Line should be 120 characters or less: currently 169 characters (line_length)

⚠️

Sources/SmileID/Classes/DocumentVerification/Model/OrchestratedDocumentVerificationViewModel.swift#L221 - Line should be 120 characters or less: currently 193 characters (line_length)

⚠️

Sources/SmileID/Classes/Networking/Models/PartnerParams.swift#L27 - Lines should not have trailing whitespace. (trailing_whitespace)

⚠️

Tests/Mocks/NetworkingMocks.swift#L33 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

⚠️

Tests/Networking/EnhancedKycTest.swift#L28 - Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

Generated by 🚫 Danger Swift against ba38d34

@jumaallan jumaallan merged commit 2a8d9cb into main Nov 14, 2023
3 checks passed
@jumaallan jumaallan deleted the feat/pass-partner-params branch November 14, 2023 15:16
JNdhlovu pushed a commit that referenced this pull request Jan 24, 2024
* Added partner params on all jobs

* Prepare 10.0.0-beta11 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants