This fixes onError not propagated to grandparent of the window (#349)

* This fixes onError not probagated to grandparent of the window * update message sending to parent window
smileidentity · Oct 10, 2024 · 39ae5c9 · 39ae5c9
1 parent 69376ca
commit 39ae5c9
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 17 deletions.
diff --git a/packages/embed/src/js/basic-kyc.js b/packages/embed/src/js/basic-kyc.js
@@ -466,7 +466,9 @@ import { version as sdkVersion } from '../../package.json';
     EndUserConsent.addEventListener(
       'end-user-consent.denied',
       () => {
-        referenceWindow.postMessage('SmileIdentity::ConsentDenied', '*');
+        [referenceWindow.parent, referenceWindow].forEach((win) => {
+          win.postMessage('SmileIdentity::ConsentDenied', '*');
+        });
         closeWindow();
       },
       false,
@@ -475,10 +477,12 @@ import { version as sdkVersion } from '../../package.json';
     EndUserConsent.addEventListener(
       'end-user-consent.totp.denied.contact-methods-outdated',
       (event) => {
-        referenceWindow.postMessage(
-          'SmileIdentity::ConsentDenied::TOTP::ContactMethodsOutdated',
-          '*',
-        );
+        [referenceWindow.parent, referenceWindow].forEach((win) => {
+          win.postMessage(
+            'SmileIdentity::ConsentDenied::TOTP::ContactMethodsOutdated',
+            '*',
+          );
+        });
         closeWindow();
       },
       false,

diff --git a/packages/embed/src/js/biometric-kyc.js b/packages/embed/src/js/biometric-kyc.js
@@ -560,7 +560,10 @@ import { version as sdkVersion } from '../../package.json';
     EndUserConsent.addEventListener(
       'end-user-consent.denied',
       () => {
-        referenceWindow.postMessage('SmileIdentity::ConsentDenied', '*');
+        (referenceWindow.parent || referenceWindow).postMessage(
+          'SmileIdentity::ConsentDenied',
+          '*',
+        );
         closeWindow();
       },
       false,

diff --git a/packages/embed/src/js/ekyc.js b/packages/embed/src/js/ekyc.js
@@ -462,7 +462,9 @@ import { version as sdkVersion } from '../../package.json';
     EndUserConsent.addEventListener(
       'end-user-consent.denied',
       () => {
-        referenceWindow.postMessage('SmileIdentity::ConsentDenied', '*');
+        [referenceWindow.parent || referenceWindow].forEach((win) => {
+          win.postMessage('SmileIdentity::ConsentDenied', '*');
+        });
         closeWindow();
       },
       false,
@@ -471,10 +473,12 @@ import { version as sdkVersion } from '../../package.json';
     EndUserConsent.addEventListener(
       'end-user-consent.totp.denied.contact-methods-outdated',
       (event) => {
-        (referenceWindow.parent || referenceWindow).postMessage(
-          'SmileIdentity::ConsentDenied::TOTP::ContactMethodsOutdated',
-          '*',
-        );
+        [referenceWindow.parent || referenceWindow].forEach((win) => {
+          win.postMessage(
+            'SmileIdentity::ConsentDenied::TOTP::ContactMethodsOutdated',
+            '*',
+          );
+        });
         closeWindow();
       },
       false,
@@ -861,9 +865,8 @@ import { version as sdkVersion } from '../../package.json';
   }
 
   function handleSuccess() {
-    (referenceWindow.parent || referenceWindow).postMessage(
-      'SmileIdentity::Success',
-      '*',
-    );
+    [referenceWindow.parent, referenceWindow].forEach((win) => {
+      win.postMessage('SmileIdentity::Success', '*');
+    });
   }
 })();
diff --git a/packages/embed/src/js/product-selection.js b/packages/embed/src/js/product-selection.js
@@ -113,8 +113,8 @@
 
     if (!validIdType) {
       const legacyValidIdType =
-        legacyProductConstraints.doc_verification[country].id_types[id_type] ||
-        legacyProductConstraints.enhanced_kyc[country].id_types[id_type];
+        legacyProductConstraints.doc_verification[country]?.id_types[id_type] ||
+        legacyProductConstraints.enhanced_kyc[country]?.id_types[id_type];
       if (legacyValidIdType) {
         validIdType = {
           name: legacyValidIdType.label,