refactor(Combobox): export as an ecmascript module (#90)

smileidentity · Oct 7, 2023 · 51740cb · 51740cb
1 parent 948e1da
commit 51740cb
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/src/doc-verification.html b/src/doc-verification.html
@@ -412,7 +412,6 @@ <h1>Submission Complete</h1>
       </section>
     </main>
 
-    <script src="js/components/Combobox.min.js"></script>
     <script src="js/doc-verification.min.js"></script>
   </body>
 </html>
diff --git a/src/js/components/Combobox.js b/src/js/components/Combobox.js
@@ -38,7 +38,7 @@ function maintainScrollVisibility(activeElement, scrollParent) {
   }
 }
 
-class Combobox extends HTMLElement {
+class ComboboxRoot extends HTMLElement {
   constructor() {
     super();
 
@@ -71,8 +71,6 @@ class Combobox extends HTMLElement {
   }
 }
 
-window.customElements.define("smileid-combobox", Combobox);
-
 class ComboboxTrigger extends HTMLElement {
   constructor() {
     super();
@@ -320,8 +318,6 @@ class ComboboxTrigger extends HTMLElement {
   }
 }
 
-window.customElements.define("smileid-combobox-trigger", ComboboxTrigger);
-
 class ComboboxListbox extends HTMLElement {
   constructor() {
     super();
@@ -528,8 +524,6 @@ class ComboboxListbox extends HTMLElement {
   }
 }
 
-window.customElements.define("smileid-combobox-listbox", ComboboxListbox);
-
 class ComboboxOption extends HTMLElement {
   connectedCallback() {
     this.setAttribute("role", "option");
@@ -577,4 +571,9 @@ class ComboboxOption extends HTMLElement {
   }
 }
 
-window.customElements.define("smileid-combobox-option", ComboboxOption);
+export default {
+  Root: ComboboxRoot,
+  Trigger: ComboboxTrigger,
+  List: ComboboxListbox,
+  Option: ComboboxOption,
+};
diff --git a/src/js/doc-verification.js b/src/js/doc-verification.js
@@ -1,6 +1,7 @@
 import "@smile_identity/smart-camera-web";
 import JSZip from "jszip";
 import { version as sdkVersion } from "../../package.json";
+import Combobox from "./components/Combobox";
 
 (function documentVerification() {
   "use strict";
@@ -16,6 +17,11 @@ import { version as sdkVersion } from "../../package.json";
   const referenceWindow = window.parent;
   referenceWindow.postMessage("SmileIdentity::ChildPageReady", "*");
 
+  window.customElements.define("smileid-combobox", Combobox.Root);
+  window.customElements.define("smileid-combobox-trigger", Combobox.Trigger);
+  window.customElements.define("smileid-combobox-listbox", Combobox.List);
+  window.customElements.define("smileid-combobox-option", Combobox.Option);
+
   let config;
   let activeScreen;
   let id_info;