refactor: extract end-user-consent component to components package
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
tamssokari
force-pushed
the
refactor/extract-end-user-consent-component-to-components-package
branch
from
45d39f5 to
ff50661
Compare
mldangelo
approved these changes
Nov 26, 2023
tamssokari
merged commit a81d5e6
into
refactor/extract-combobox-to-components-package
7 checks passed
tamssokari
deleted the
refactor/extract-end-user-consent-component-to-components-package
branch
tamssokari
added a commit
that referenced
this pull request
Nov 26, 2023
* refactor: move combobox component to components package * ci: deploy preview on PRs to all branches * deps: add `@smileid/components` as dependency of `@smileid/embed` * refactor: use local paths for workspace dependencies * refactor: extract `end-user-consent` component to `components` package (#142)
tamssokari
added a commit
that referenced
this pull request
Nov 28, 2023
* refactor: rename `components` to `smart-camera-web` * ci: modify github workflows for smart-camera-web package * embed: update package name, dependencies * refactor: use local path for cross-package dependencies * refactor: move combobox component to components package (#141) * refactor: move combobox component to components package * ci: deploy preview on PRs to all branches * deps: add `@smileid/components` as dependency of `@smileid/embed` * refactor: use local paths for workspace dependencies * refactor: extract `end-user-consent` component to `components` package (#142) * refactor: extract totp-consent to components package (#143) * refactor: move combobox component to components package * ci: deploy preview on PRs to all branches * deps: add `@smileid/components` as dependency of `@smileid/embed` * refactor: extract `end-user-consent` component to `components` package * refactor: extract totp-consent to components package * refactor: use `<totp-consent>` as the markup * refactor: rename `totp-consent` in tests * docs: update README to reflect packages update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.