Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract totp-consent to components package #143

Merged
merged 8 commits into from
Nov 26, 2023
Merged

refactor: extract totp-consent to components package #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
07b5b3a
refactor: move combobox component to components package
Nov 26, 2023
fd08937
ci: deploy preview on PRs to all branches
Nov 26, 2023
1f28d3a
deps: add `@smileid/components` as dependency of `@smileid/embed`
Nov 26, 2023
ff50661
refactor: extract `end-user-consent` component to `components` package
Nov 26, 2023
7622f69
refactor: extract totp-consent to components package
Nov 26, 2023
2667962
refactor: use `<totp-consent>` as the markup
Nov 26, 2023
fbafac7
refactor: rename `totp-consent` in tests
Nov 26, 2023
87fcca7
Merge branch 'packages/rename-components-to-smart-camera-web' into re…
tamssokari Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/components/end-user-consent/src/EndUserConsent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ function templateString() {
</section>
</div>

<totp-consent-app
<totp-consent
hidden
base-url='${this.baseUrl}'
country='${this.country}'
Expand All @@ -492,7 +492,7 @@ function templateString() {
partner-name='${this.partnerName}'
token='${this.token}'
>
</totp-consent-app>
</totp-consent>

<div hidden id='consent-rejected-screen' class='flow'>
<section class='flow center'>
Expand Down Expand Up @@ -674,7 +674,7 @@ class EndUserConsent extends HTMLElement {
this.shadowRoot.appendChild(template.content.cloneNode(true));

this.consentScreen = this.shadowRoot.querySelector("#consent-screen");
this.totpConsentApp = this.shadowRoot.querySelector("totp-consent-app");
this.totpConsentApp = this.shadowRoot.querySelector("totp-consent");
this.consentRejectedScreen = this.shadowRoot.querySelector(
"#consent-rejected-screen",
);
Expand Down
12 changes: 9 additions & 3 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,15 @@
"exports": {
".": "./index.js",
"./combobox": "./combobox/src/index.js",
"./end-user-consent": "./end-user-consent/src/index.js"
"./end-user-consent": "./end-user-consent/src/index.js",
"./totp-consent": "./totp-consent/src/index.js"
},
"description": "A collection of Web Components used by SmileID",
"keywords": [ "Web Components" ],
"author": "SmileID <[email protected]> (https://usesmileid.com)"
"keywords": [
"Web Components"
],
"author": "SmileID <[email protected]> (https://usesmileid.com)",
"dependencies": {
"validate.js": "^0.13.1"
}
}
10 changes: 8 additions & 2 deletions ...embed/src/js/components/TotpConsentApp.js → ...omponents/totp-consent/src/TotpConsent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ function markup() {
`;
}

class TotpBasedConsent extends HTMLElement {
class TotpConsent extends HTMLElement {
constructor() {
super();

Expand Down Expand Up @@ -923,4 +923,10 @@ class TotpBasedConsent extends HTMLElement {
}
}

export default TotpBasedConsent;
if ("customElements" in window) {
window.customElements.define('totp-consent', TotpConsent);
}

export {
TotpConsent,
};
3 changes: 3 additions & 0 deletions packages/components/totp-consent/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export {
TotpConsent
} from './TotpConsent';
2 changes: 1 addition & 1 deletion packages/embed/cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ Cypress.Commands.add("getTotpConsentApp", () => {
cy.getIFrameBody()
.find("end-user-consent")
.shadow()
.find("totp-consent-app")
.find("totp-consent")
.shadow();
});

Expand Down
4 changes: 1 addition & 3 deletions packages/embed/src/js/basic-kyc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import validate from "validate.js";
import "@smileid/components/combobox";
import "@smileid/components/end-user-consent";
import TotpBasedConsent from "./components/TotpConsentApp";
import "@smileid/components/totp-consent";
import { version as sdkVersion } from "../../package.json";

(function basicKyc() {
Expand All @@ -19,8 +19,6 @@ import { version as sdkVersion } from "../../package.json";
const referenceWindow = window.parent;
referenceWindow.postMessage("SmileIdentity::ChildPageReady", "*");

window.customElements.define("totp-consent-app", TotpBasedConsent);

const pages = [];
let activeScreen;
let config;
Expand Down
4 changes: 1 addition & 3 deletions packages/embed/src/js/biometric-kyc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import JSZip from "jszip";
import validate from "validate.js";
import "@smile_identity/smart-camera-web";
import "@smileid/components/end-user-consent";
import TotpBasedConsent from "./components/TotpConsentApp";
import "@smileid/components/totp-consent";
import { version as sdkVersion } from "../../package.json";

(function biometricKyc() {
Expand All @@ -20,8 +20,6 @@ import { version as sdkVersion } from "../../package.json";
const referenceWindow = window.parent;
referenceWindow.postMessage("SmileIdentity::ChildPageReady", "*");

window.customElements.define("totp-consent-app", TotpBasedConsent);

const pages = [];
let activeScreen;
let config;
Expand Down
3 changes: 1 addition & 2 deletions packages/embed/src/js/ekyc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import validate from "validate.js";
import "@smileid/components/combobox";
import "@smileid/components/end-user-consent";
import TotpBasedConsent from "./components/TotpConsentApp";
import "@smileid/components/totp-consent";
import { version as sdkVersion } from "../../package.json";

(function eKYC() {
Expand All @@ -18,7 +18,6 @@ import { version as sdkVersion } from "../../package.json";

const referenceWindow = window.parent;
referenceWindow.postMessage("SmileIdentity::ChildPageReady", "*");
window.customElements.define("totp-consent-app", TotpBasedConsent);

const pages = [];
let activeScreen;
Expand Down