Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed: add e-signature product #150

Merged
merged 47 commits into from
Jan 25, 2024
Merged

embed: add e-signature product #150

merged 47 commits into from
Jan 25, 2024

Conversation

tamssokari
Copy link
Contributor

@tamssokari tamssokari commented Dec 4, 2023

this adds e-signature product to the iframe embed

Steps to Test

Copy link

gitguardian bot commented Dec 4, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8967277 Generic High Entropy Secret 89a6c00 packages/embed/cypress/fixtures/e_signature_documents.json View secret
8967277 Generic High Entropy Secret 89a6c00 packages/embed/cypress/fixtures/e_signature_documents.json View secret
8967278 Generic High Entropy Secret 89a6c00 packages/embed/cypress/fixtures/e_signature_documents.json View secret
8967278 Generic High Entropy Secret 89a6c00 packages/embed/cypress/fixtures/e_signature_documents.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

github-actions bot commented Dec 4, 2023

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-embed/add-e_signature/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-embed/add-e_signature/js/script.min.js

@tamssokari tamssokari requested a review from ayinloya January 25, 2024 15:21
@tamssokari tamssokari self-assigned this Jan 25, 2024
Copy link
Collaborator

@ayinloya ayinloya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tamssokari tamssokari marked this pull request as ready for review January 25, 2024 18:34
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-embed/add-e_signature/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-embed/add-e_signature/js/script.min.js

@tamssokari tamssokari merged commit 5027ff7 into main Jan 25, 2024
9 checks passed
@tamssokari tamssokari deleted the embed/add-e_signature branch January 25, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants