Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign: rotate active / default button colors #153

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

tamssokari
Copy link
Contributor

@tamssokari tamssokari commented Dec 8, 2023

Test Instructions

  • Pull the branch locally, or use the dev preview link
  • verify that buttons show blue as default color, and black on hover

@tamssokari tamssokari requested a review from ayinloya December 8, 2023 12:59
@tamssokari tamssokari self-assigned this Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-redesign/change-primary-button-colors/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-redesign/change-primary-button-colors/js/script.min.js

Copy link
Collaborator

@ayinloya ayinloya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelakintunde
Copy link

Hello @tamssokari

it seems we have a mix up somewhere, our button states should be

Active state - Blue
Default state - Black
Inactive state - Grey

Please see example on Figma here

@tamssokari
Copy link
Contributor Author

Hello @tamssokari

it seems we have a mix up somewhere, our button states should be

Active state - Blue Default state - Black Inactive state - Grey

Please see example on Figma here

this was the existing implementation called out to be changed. mobile does the inverse, and this PR was to make the web do same

@samuelakintunde
Copy link

Hello @tamssokari
it seems we have a mix up somewhere, our button states should be
Active state - Blue Default state - Black Inactive state - Grey
Please see example on Figma here

this was the existing implementation called out to be changed. mobile does the inverse, and this PR was to make the web do same

@Yeboahmedia..... please is this true? I think i am a bit confused here

@Yeboahmedia
Copy link

You

Hello @tamssokari
it seems we have a mix up somewhere, our button states should be
Active state - Blue Default state - Black Inactive state - Grey
Please see example on Figma here

this was the existing implementation called out to be changed. mobile does the inverse, and this PR was to make the web do same

@Yeboahmedia..... please is this true? I think I am a bit confused here

You are correct @samuelakintunde; this is how buttons should be represented on the web
@tamssokari let's keep this reverse implementation on the web.
The reason being it makes to develop mobile-first/responseive.
However, we need a story to target web screens seperately in the components so we can get the proper behaviours we intend for our design.

@tamssokari I thought the comment from the Show/tell was related to we having a disabled state (grey button) for the unticked state in the e-signature review-documents page

@tamssokari tamssokari merged commit 6444c2e into main Dec 14, 2023
@tamssokari tamssokari deleted the redesign/change-primary-button-colors branch December 14, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants