-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign: rotate active / default button colors #153
Conversation
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello @tamssokari it seems we have a mix up somewhere, our button states should be Active state - Blue Please see example on Figma here |
this was the existing implementation called out to be changed. mobile does the inverse, and this PR was to make the web do same |
@Yeboahmedia..... please is this true? I think i am a bit confused here |
You
You are correct @samuelakintunde; this is how buttons should be represented on the web @tamssokari I thought the comment from the Show/tell was related to we having a disabled state (grey button) for the unticked state in the e-signature |
Test Instructions
cd packages/embed
npm ci
npm run build && npm start