Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Components] Adds document capture instruction screen #176

Merged
merged 56 commits into from
Jan 23, 2024
Merged

[Components] Adds document capture instruction screen #176

merged 56 commits into from
Jan 23, 2024

Conversation

ayinloya
Copy link
Collaborator

@ayinloya ayinloya commented Jan 19, 2024 •
edited
Loading

This adds instruction screen for document capture.

Install dependencies localling npm install
Run npm run storybook
Open http://localhost:6006/ to few the stories
Under the document-instructions - verify that the instructions are rendered correctly

depends on [ehn] Refactor SmartCamera and SmartFileUpload

ayinloya added 30 commits December 6, 2023 11:07
@ayinloya
Add selfi instruction screen
49adf0e
@ayinloya
reformat
03df0a5
@ayinloya
Remove unused methods
dfdf6e4
@ayinloya
Add Document instruction template
82f5176
@ayinloya
Add document instruction
e85b318
@ayinloya
Merge branch 'main' into configurable-screens
a7dbe7b
@ayinloya
show new document entry screen
e4807d4
@ayinloya
Handle take photo butotn click
7d9693f
@ayinloya
Add refactored components
fb7159e
@ayinloya
Handle file upload
caea4da 
Handle back navigation in back of id
@ayinloya
Allow skipping document capture
002b993
@ayinloya
Rename hide to skip
d89befa
@ayinloya
Update tests
3fad8db
@ayinloya
Update accept and retry buttons in id review page
d7a7fa6
@ayinloya
Update camera display
207a403
@ayinloya
Merge branch 'main' into configurable-screens
0c987bb
@ayinloya
Remove border in id camera and review pages
bc2e1ae 
Add text button to review
Update image height in review
@ayinloya
Add note about glare in review screens
2f79a71
@ayinloya
Add id review component
7ec5da0 
Fix DocumentInstruction story
@ayinloya
Use new component, IdReview in smart camera web
8f12d87 
Fix review image display
@ayinloya
Merge branch 'main' into configurable-screens
b2e9579
@ayinloya
Fix recapture
2efb12c
@ayinloya
Update smart camera tests
bdbedd5
@ayinloya
Support capture modes in document-instruction
0f1c05f
@ayinloya
Update smart web camera tests
6aa7aac
@ayinloya
Refactor id capture and instruction screens to new directories
f1704b3
@ayinloya
Refactor id capture and instruction screens to new directories
de795c1
@ayinloya
Merge branch 'configurable-screens' of github.com:smileidentity/web-c…
3e426c2 
…lient into configurable-screens
@ayinloya
remove duplicate screen
e27a732
@ayinloya
Set stream in document capture component
982ea64 
Update video preview to capture more context
Add styles and typography
@ayinloya ayinloya self-assigned this Jan 19, 2024
@github-actions GitHub Actions
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-add-document-capture-instructions/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-add-document-capture-instructions/js/script.min.js

@ayinloya ayinloya changed the title Adds document capture instruction screen [Components] Adds document capture instruction screen Jan 19, 2024
@ayinloya ayinloya requested a review from tamssokari January 19, 2024 11:56
@ayinloya ayinloya mentioned this pull request Jan 19, 2024
Merged
@ayinloya
Copy link
Collaborator Author

https://app.shortcut.com/smileid/story/11141/refactor-the-web-components-and-ensure-partners-can-decide-what-they-want-to-capture

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #11141: Refactor the Web Components and ensure partners can decide what they want to capture.

mldangelo
mldangelo reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@mldangelo mldangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for breaking these apart. How do we consume this? Is it identical to the existing capture screen? Consider adding context in a readme, etc. I'll run this and LGTM after standup.

@ayinloya
Copy link
Collaborator Author

Thank you for breaking these apart. How do we consume this? Is it identical to the existing capture screen? Consider adding context in a readme, etc. I'll run this and LGTM after standup.

The design is updated to follow the new figma designs https://www.figma.com/proto/nGpsaJvMsCBgjIYaVAx0up/Hosted-Web-Add-Document-Upload_Jan_wip?type=design&node-id=604-629&t=sovnaKnE3WAEkjSs-0&scaling=min-zoom&page-id=604%3A276&starting-point-node-id=604%3A629

@ayinloya
Copy link
Collaborator Author

Depending on the partner needs, they can use which ever component build their own flow

Base automatically changed from configurable-screens to main January 23, 2024 10:41
@ayinloya ayinloya merged commit ac2d3d9 into main Jan 23, 2024
5 checks passed
@ayinloya ayinloya deleted the add-document-capture-instructions branch January 23, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mldangelo mldangelo mldangelo left review comments

@tamssokari tamssokari tamssokari approved these changes

@Yeboahmedia Yeboahmedia Awaiting requested review from Yeboahmedia

Assignees

@ayinloya ayinloya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayinloya @mldangelo @tamssokari @beastawakens