-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components] Add document capture #179
Conversation
Handle back navigation in back of id
Add text button to review Update image height in review
Fix DocumentInstruction story
Fix review image display
…lient into configurable-screens
Update video preview to capture more context Add styles and typography
Fix file selector Copy fileupload class to components
Move document capture to new branch
This branch has been deployed to s3 / cloudfront. ✅ Preview URL for Smart Camera Web: |
This pull request has been linked to Shortcut Story #11141: Refactor the Web Components and ensure partners can decide what they want to capture. |
@@ -6,7 +6,8 @@ | |||
".": "./index.js", | |||
"./combobox": "./combobox/src/index.js", | |||
"./end-user-consent": "./end-user-consent/src/index.js", | |||
"./totp-consent": "./totp-consent/src/index.js" | |||
"./totp-consent": "./totp-consent/src/index.js", | |||
"./document-capture": "./document-capture/src/index.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the entry point for capturing and combines both the instruction, capture and review into a single flow.
We could export the other components too but only the IDCapture component might be useful on it's own
"./totp-consent": "./totp-consent/src/index.js", | ||
"./document-capture": "./document-capture/src/index.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, sort
<document-capture | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<document-capture | |
> | |
<document-capture> |
<document-capture | ||
hide-instructions | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the indentation feels weird on these. Make sure it makes sense to you.
hide-back-of-id | ||
hide-instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hide-back-of-id | |
hide-instructions | |
hide-back-of-id | |
hide-instructions |
depends on #178