Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Add document capture #179

Merged
merged 57 commits into from
Jan 24, 2024
Merged

[components] Add document capture #179

merged 57 commits into from
Jan 24, 2024

Conversation

ayinloya
Copy link
Collaborator

@ayinloya ayinloya commented Jan 19, 2024

  • Install dependencies localling npm install
  • Run npm run storybook
  • Open http://localhost:6006/ to few the stories
  • Under the DocumentCapture test out the different scenarios and verify the outcome
  • Capture With instruction screen
  • Capture without instructions screen
  • Capture without back of id screen

depends on #178

Handle back navigation in back of id
Add text button to review
Update image height in review
Fix DocumentInstruction story
Update video preview to capture more context
Add styles and typography
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-add-document-capture/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-add-document-capture/js/script.min.js

@ayinloya ayinloya self-assigned this Jan 19, 2024
@ayinloya ayinloya requested a review from tamssokari January 19, 2024 12:00
Copy link

@ayinloya ayinloya requested a review from Yeboahmedia January 19, 2024 12:11
@@ -6,7 +6,8 @@
".": "./index.js",
"./combobox": "./combobox/src/index.js",
"./end-user-consent": "./end-user-consent/src/index.js",
"./totp-consent": "./totp-consent/src/index.js"
"./totp-consent": "./totp-consent/src/index.js",
"./document-capture": "./document-capture/src/index.js"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is package.json changing for this PR but not #178 and #177 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the entry point for capturing and combines both the instruction, capture and review into a single flow.
We could export the other components too but only the IDCapture component might be useful on it's own

Comment on lines +9 to +10
"./totp-consent": "./totp-consent/src/index.js",
"./document-capture": "./document-capture/src/index.js"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, sort

Comment on lines 11 to 12
<document-capture
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<document-capture
>
<document-capture>

Comment on lines 19 to 21
<document-capture
hide-instructions
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the indentation feels weird on these. Make sure it makes sense to you.

Comment on lines 47 to 48
hide-back-of-id
hide-instructions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hide-back-of-id
hide-instructions
hide-back-of-id
hide-instructions

Base automatically changed from add-id-review to main January 24, 2024 12:47
@ayinloya ayinloya merged commit 4df97eb into main Jan 24, 2024
6 checks passed
@ayinloya ayinloya deleted the add-document-capture branch January 24, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants