Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End user consent update #195

Merged
merged 5 commits into from
Jan 29, 2024
Merged

End user consent update #195

merged 5 commits into from
Jan 29, 2024

Conversation

ayinloya
Copy link
Collaborator

This updates the Enduser consent ui to follow the design here

Run nom run storybook
Visit http://localhost:6006/?path=/story/end-user-consent-src-enduserconsent--end-user-consent
Verify the UI is updated and follows the design closely

@ayinloya ayinloya self-assigned this Jan 26, 2024
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-end-user-consent-update/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-end-user-consent-update/js/script.min.js

Copy link
Contributor

@mldangelo mldangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks @ayinloya. One nit.

packages/components/end-user-consent/src/EndUserConsent.js Outdated Show resolved Hide resolved
Comment on lines +24 to +26
--color-danger: #FF5805;

--color-primary-blue: #151F72;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should figure out how to re-use these (and lint them)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, will think of a way

@ayinloya ayinloya merged commit cb68e69 into main Jan 29, 2024
9 checks passed
@ayinloya ayinloya deleted the end-user-consent-update branch January 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants