Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlay on the review image #196

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Add overlay on the review image #196

merged 2 commits into from
Jan 29, 2024

Conversation

ayinloya
Copy link
Collaborator

@ayinloya ayinloya commented Jan 26, 2024

This adds an overlay on top of the review image to hide the extra context taken during id capture.

The captured image will still include the extra context when uploading.

  • Checkout on main
  • Run npm run storybook
  • Capture an ID card
  • Verify that the extra context is shown
  • Checkout on this branch
  • Capture an ID card
  • Verify that the context is hidden

Before

Screenshot 2024-01-26 at 3 44 23 PM

After

Screenshot 2024-01-26 at 3 45 40 PM

@ayinloya ayinloya self-assigned this Jan 26, 2024
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL for Smart Camera Web:
https://cdn.smileidentity.com/js/preview-update-id-review-screen/smart-camera-web.js
✅ Preview URL for Embed:
https://cdn.smileidentity.com/inline/preview-update-id-review-screen/js/script.min.js

@ayinloya ayinloya enabled auto-merge (squash) January 26, 2024 15:48
@mldangelo
Copy link
Contributor

@andy-smileid Can you review this one?

Copy link

@andy-smileid andy-smileid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Barnabas.

LGTM and happy to see this going in.

Some things to consider in the future:

  • The region shown to the user during capture should be exactly the same region shown on this verification view and I'd be happy to check this later (including aspect ratio).
  • We are leaving out text referencing that all the text on the card must be readable (a high % of jobs are rejected because the text is blurry). Button answer a question that was not explicitly posed and does not relate directly to text above (we are asking about corners and glare and answering re whether it's readable. Anyway, just saying the text here is a bit murky and should be clarified in the future (and match precisely our mobile SDKs).

@ayinloya ayinloya merged commit 3f2cf09 into main Jan 29, 2024
9 checks passed
@ayinloya ayinloya deleted the update-id-review-screen branch January 29, 2024 15:03
@andy-smileid
Copy link

andy-smileid commented Jan 29, 2024

  • Also for the future, we should display the cropped image in the largest possible frame instead of cropping the image into a smaller region.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants