Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reorganize components for publishing #201

Merged
merged 40 commits into from
Mar 5, 2024
Merged

chore: reorganize components for publishing #201

merged 40 commits into from
Mar 5, 2024

Conversation

tamssokari
Copy link
Contributor

@tamssokari tamssokari commented Jan 31, 2024 •
edited by ayinloya
Loading

This reorganises the components in web-components for publications.

Testing

  • Install dependencies npm install
  • Run storybook npm run storybook
  • View the stories to see nothing is broken
  • Ran npm publish --dry-run
  • Verify the files included

@tamssokari tamssokari requested a review from ayinloya January 31, 2024 18:09
@tamssokari tamssokari self-assigned this Jan 31, 2024
tams sokari and others added 13 commits January 31, 2024 13:25
@ayinloya
Copy link
Collaborator

ayinloya commented Feb 9, 2024

https://app.shortcut.com/smileid/story/11141/refactor-the-web-components-and-ensure-partners-can-decide-what-they-want-to-capture

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #11141: Refactor the Web Components and ensure partners can decide what they want to capture.

@mldangelo
Copy link
Contributor

@ayinloya asked me for a review in his standup update. Can you please document the structure in your README.md file and address your CI failure?

Are you sure your test instructions are sufficient for this change?

@tamssokari
Copy link
Contributor Author

co-authorship bias is why I haven't reviewed this.

I'll leave comments if any though.

tamssokari
tamssokari commented Mar 4, 2024
View reviewed changes
Copy link
Contributor Author

@tamssokari tamssokari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is no longer needed, as we are no longer publishing the components independently.

packages/web-components/components/document-capture/.storybook/main.js Outdated Show resolved Hide resolved
packages/web-components/components/document-capture/.eslintrc.js Outdated Show resolved Hide resolved
packages/web-components/components/document-capture/.storybook/preview.js Outdated Show resolved Hide resolved
tamssokari
tamssokari commented Mar 5, 2024
View reviewed changes
Copy link
Contributor Author

@tamssokari tamssokari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now.

Can't approve as author though

ayinloya
ayinloya approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@ayinloya ayinloya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went through this together, Looks good

@tamssokari tamssokari merged commit ba4eedc into main Mar 5, 2024
8 checks passed
@tamssokari tamssokari deleted the chore/fix-workspaces-for-components-publishing branch March 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayinloya ayinloya ayinloya approved these changes

@solnsubuga solnsubuga Awaiting requested review from solnsubuga

@mldangelo mldangelo Awaiting requested review from mldangelo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamssokari @ayinloya @mldangelo