Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(DocVerification): support global document verification #57

Merged
merged 46 commits into from
Oct 5, 2023
Merged

enh(DocVerification): support global document verification #57

merged 46 commits into from
Oct 5, 2023

Conversation

tamssokari
Copy link
Contributor

@tamssokari tamssokari commented Sep 14, 2023 •
edited
Loading

This PR contains a few changes

  • uses valid_documents instead of services to load documents for UI
  • uses has_back entry to control back of id capture
  • introduces new autocomplete component for country selection
  • introduces new dropdown component for id_type information
  • upgrades smart-camera-web to support dismissible back of ID capture screen

Steps to Test

Steps to Deploy

Before Deploy

  • Bump Version number for Doc V
  • Update Smart Camera Web to Published version for all products
  • Deploy as normal

@github-actions
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL: https://cdn.smileidentity.com/inline/preview-enh/global-doc-verification/js/script.js

@tamssokari tamssokari self-assigned this Sep 14, 2023
@tamssokari tamssokari marked this pull request as ready for review September 20, 2023 20:35
@github-actions
Copy link

This branch has been deployed to s3 / cloudfront.

✅ Preview URL: https://cdn.smileidentity.com/inline/preview-enh/global-doc-verification/js/script.js

nii-mants3
nii-mants3 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@nii-mants3 nii-mants3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

src/js/basic-kyc.js Outdated
@@ -4,7 +4,6 @@ var basicKyc = (function basicKyc() {
// NOTE: In order to support prior integrations, we have `live` and
// `production` pointing to the same URL
const endpoints = {
development: "https://devapi.smileidentity.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious as to why we are removing the development url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is public facing, so we don't want it known.

ayinloya
ayinloya approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@ayinloya ayinloya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamssokari tamssokari requested a review from mldangelo October 3, 2023 23:08
mldangelo
mldangelo approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mldangelo mldangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tamssokari tamssokari merged commit b9b077e into main Oct 5, 2023
4 checks passed
@tamssokari tamssokari deleted the enh/global-doc-verification branch October 5, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mldangelo mldangelo mldangelo approved these changes

@ayinloya ayinloya Awaiting requested review from ayinloya

@nii-mants3 nii-mants3 Awaiting requested review from nii-mants3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tamssokari @mldangelo @ayinloya @nii-mants3