Merge smart camera web #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.0.0-beta.1
* fix(layout-shift): add image dimension hints for preview image * tests: add cypress test for id-capture flow * docs: add `capture-id`, and other enhancements. * refactor: use graphical 1k (1024) * 1.0.0-beta.3
* enh: add `back of ID` capture * tests: add tests for capture back of id * 1.0.0-beta.4 * refactor: use `setActiveScreen` and `activeScreen` to switch screens * 1.0.0-beta.4
* refactor: do not set z-index of video * refactor: use `prepend` for selfie video * refactor: use single `<video>` element, do not re-create on each retry * refactor: change version number * 1.0.0-beta.5 * 1.0.0-beta.5
* refactor: fix stacking context for id-images * refactor: bump version * 1.0.0-beta.6
* redesign: back of id should have `image_type_id` of 7 * version: update version in docs / source * 1.0.0-beta.7
* fix: remove all links to smileidentity.com * 1.0.0-beta.8
* refactor(IDImage): change id image dimensions * refactor: use rounded height dimension * refactor: maintain aspect ratio in dimensions
* redesign: increase liveness image capture duration * refactor: change animation duration for smile prompt
…#12) * enh: add zoom level for samsung multi-camera devices * fix: typo in `isSamsungMultiCameraDevice` * fix: add ui style tweaks * fix * enh: add some UI enhancements
* Enhance Liveness and Document Capture Features - Increase Liveness Image capture duration to 8s - Add Zoom Level for Document Capture for multi-camera Android devices - Change Document capture image frame from white to red - Remove Document capture image frame from review screens * build: revert package.json update, update deps * 1.0.0-beta.11
* Refactor render logic Remove listeners on disconnect * Reset shadow root to prevent duplicate when removed and appended to parent * Remove the resetlisteners function * Allow reset of component * Add test for smart camera screen reset * Verify request-screen is visible after reset reduce wait time in test reindent template
* meta: update VERSION number * fix: fix font url * refactor: change markup function to named function * redesign: use `hide-attribution` attribute to hide attribution * tests: test `hide-attribution` atttribute * config: update version to beta.14 * config: bump version to v1.0.0-beta.15
* Add slot for custom back button * Add test for custom back button * Add back button tests for all screens * Update smart-camera-web.js Co-authored-by: tams sokari <[email protected]> * Update smart-camera-web.js * Update back button and exit buttons Update tests * remove unused variable * Add option to hide back buttons that go back to the host app * Increase back button text size * Add test: back to host button --------- Co-authored-by: tams sokari <[email protected]>
* Update package version Add cypress test output to gitignore
* config: bump node version to v18.16.0 * deps: upgrade dependencies to latest versions * migration: migrate cypress tests to latest format * config: bump cypress-io/github-action version * refactor: move html files into `cypress/pages` folder * fix: move instrumented files to pages folder on build
* Implement portrait capture. * Add eslint. * Change NATIONAL_ID_DOC to GREEN_BOOK. * Add an observer for the document type attribute. * Add logs for QA. * Update log. * Cleanups. * Use inline JS inside the markup template. * Update package version. * Use a combination of observer and static get. * Add logs for QA. * Update HTML markup when the document type attribute changes. * Cleanups. * Include previous change. * Constrain view within fixed sized area. * Add extra padding. * Add left spacing. * Adjust button width.
* wip * wip: tying it all together * redesign: smart-camera-web redesign shelved for separate PR * redesign: restore legacy smart-camera-web to working code * wip * tests: add `do-not-upload` attribute to all existing tests * redesign: change from "Nunito Sans" to "Nunito" font * redesign: switch between camera and entry screens for document capture * refactor: remove todo.txt file * fix: fix broken tests * redesign: add upload document functionality * add styling for document upload, finalize design * tests: add page for tests / local development * refactor: remove new smart-camera-web component * refactor: remove commented code in `handleError` * refactor: remove redundant async from `SmartFileUpload.getData`, promise is returned * redesign: handle file reader errors in `SmartFileUpload.getData` * refactor: add comment explaining why we split dataURL strings * redesign: switch action button sequence * redesign: change max file size to 10mb * redesign: add image resolution check for uploaded documents * redesign: add `document-capture-mode` attribute, defaults to `both` * fix: add event listeners conditionally * redesign: observe `document-capture-mode` attributes for changes * fix: attach event listeners after rewriting dom * refactor: extract `setUpEventListeners` into its own function * refactor: move event listener to `setUpEventListeners` function * fix(styles): conditionally apply classes when upload document-capture-mode is selected * fix: clear value when file input is clicked, enabling selection of same file * refactor: always show entry screens for document capture * tmp: disable test requirements * refactor: use getter for `captureBackOfID` * copy: change copy for document capture entry screens * redesign: fix conditional rendering * fix: run linter to minimize merge conflicts * enh: restart from main * fix: fix lint config, and run linter * version: bump version number to 1.0.0-beta.18 * enh: add `SmartFileUpload` class for processing uploads * redesign: switch from Nunito Sans to Nunito * redesign: move confirm actions to right, and review to left * config: bump version number * redesign: remove unnecessary variable declaration * refactor: remove redundant code, reorder, and rewrite * enh: add document upload functionality, without triggers * refactor: add entry screens for document capture, modify tests * Revert "tmp: disable test requirements" This reverts commit 8dfaf4cadc2cf2e16f2926e29d8d8aa39d225c23. * redesign: remove height restriction on reviewed document images * redesign: add `document-capture-mode` to observed-attributes * refactor: make `color-digital-blue` have highest specificity * fix: fix svg dimension error, remove max-height on preview * enh: add extra back / close buttons on the document capture entry screens * styles: use consistent styling in document entry screens * tests: add command to navigate through face capture screens * redesign: change image dimension error message copy * enh: add image dimension tip * tests: add document-upload tests * format: run linter * redesign: remove dimension restriction * redesign: use `document-capture-modes`, and change default to `camera` * styles: change entry-screen block-size to 45rem * refactor: use attributes and conditional rendering for back buttons * fix: reset `_rawImages` when restarting image capture for POL
* styles: change font to DM Sans * redesign: introduce `powered-by-smile-id` component for attribution * redesign: change button components to match new brand * refactor: change image outline color to use interactive color * refactor: update attribution test * refactor: change active color * version: bump to 1.0.0-beta.19 * 1.0.0-beta.19 * deps: update package-lock.json * redesign: add border to solid buttons * redesign: add transparent for actions icons
…een screen issues (#35) * redesign: check if explicit calls to video.play() prevents black screen issues * enh: add `muted` attribute to video stream * version: bump version number to v1.0.0-beta.42 * 1.0.0-beta.22
* redesign: change back button icon / font color * redesign: switch close icon * redesign: reinstate tips for back of document capture * redesign: remove auto margin for actions on id entry screens * enh: add "Skip this step" button for back of id photo this shows up only when a document-type does not exist * 1.0.0-beta.23 * redesign: use image-frame to crop id image
|
@tamssokari if this is a direction you believe worth persuing, I'll resolve merge conflicts. If not, I can close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick proof of concept that combines smart-camera-web and hosted-web-integration into the same mono-repo while preserving git history. I carefully merged all of the github actions. They still have separate package.json files and I have not migrated any of the git tags.
Let's discuss next week.