Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to ESM module #83

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Convert to ESM module #83

merged 5 commits into from
Oct 3, 2023

Conversation

mldangelo
Copy link
Contributor

Requested by @tamssokari This converts the repo to an esm module. As a result, the bundle sizes are a few bytes smaller.

Cypress tests are still written in common js.

Test Instructions

Verify that the tests pass.

@mldangelo mldangelo requested review from vanshg and tamssokari October 3, 2023 22:11
@mldangelo mldangelo self-assigned this Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This branch has been deployed to s3 / cloudfront.

✅ Preview URL: https://cdn.smileidentity.com/inline/preview-esm/js/script.js

@mldangelo mldangelo enabled auto-merge (squash) October 3, 2023 22:24
@mldangelo mldangelo merged commit 668e907 into main Oct 3, 2023
@mldangelo mldangelo deleted the esm branch October 3, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants