Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiline headers in HTTP parsing #653

Open
1 task done
ianbotsf opened this issue Jun 1, 2022 · 1 comment
Open
1 task done

Support multiline headers in HTTP parsing #653

ianbotsf opened this issue Jun 1, 2022 · 1 comment
Labels
enhancement New feature or request no-auto-closure We do not want this issue to be automatically closed.

Comments

@ianbotsf
Copy link
Contributor

ianbotsf commented Jun 1, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment

Describe the Feature

The current HTTP layer via ktor-http-cio does not support parsing multiline headers (because they are deprecated) or paths with spaces in them. We should make our parsing layer capable of handling these edge cases.

Is your Feature Request related to a problem?

The lack of parser flexibility means that some of the SigV4 signing suite tests have to be disabled (get-header-value-multiline, get-space-normalized, and get-space-unnormalized).

Proposed Solution

Possibly replace ktor-http-cio as the HTTP layer.

Describe alternatives you've considered

(none)

Additional Context

(none)

  • I may be able to implement this feature request
@jason-weddington
Copy link

Need to investigate the current state after moving away from ktor.

@ianbotsf ianbotsf added the no-auto-closure We do not want this issue to be automatically closed. label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-auto-closure We do not want this issue to be automatically closed.
Projects
None yet
Development

No branches or pull requests

2 participants