feat: implementation of standard AWS signer #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Jun 1, 2022
| // ktor-http-cio parser doesn't support parsing multiline headers since they are deprecated in RFC7230 | ||
| "get-header-value-multiline", | ||
| // ktor fails to parse with space in it (expects it to be a valid request already encoded) | ||
| "get-space-normalized", |
There was a problem hiding this comment.
We should probably address these as they are mostly limitations of the parser in use. In particular the space ones since IIRC rust had some issues with this. I don't think we need to block this PR over it but we should make a task for it.
There was a problem hiding this comment.
Yep yep, created #653 and will note it in a TODO around these tests.
|
|
||
| private const val PANGRAM = "The quick brown fox jumps over the lazy dog" | ||
|
|
||
| class HmacTest { |
There was a problem hiding this comment.
fix: We should really use more official test vectors like the ones provided in rfc-4231 section 4.
Sorry for not catching this before
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#617
Description of changes
Merge signer feature branch into main. All of these changes should've been reviewed in #635 and #637.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.