Skip to content

Commit

Permalink
Suppress flaky integ tests
Browse files Browse the repository at this point in the history
This moves some integ tests that were incorrectly put into unit tests
and additionally marks them as skipped. They're being skipped because
they've become flaky, likely due to some changes on the host side that
we can't control. They should ultimately be replaced with unit tests.
  • Loading branch information
JordonPhillips committed Jun 26, 2024
1 parent 4e88bdb commit ccc13e7
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 0 deletions.
Empty file.
Empty file.
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX-License-Identifier: Apache-2.0
import pytest

from smithy_http.aio import HTTPRequest
from smithy_http.aio.aiohttp import AIOHTTPClient, AIOHTTPClientConfig


@pytest.mark.skip("Needs to be replaced with a functional test due to flakiness.")
async def test_basic_request_local(sample_request: HTTPRequest) -> None:
config = AIOHTTPClientConfig()
session = AIOHTTPClient(client_config=config)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX-License-Identifier: Apache-2.0
import pytest

from smithy_http.aio import HTTPRequest
from smithy_http.aio.crt import AWSCRTHTTPClient, AWSCRTHTTPClientConfig


@pytest.mark.skip("Needs to be replaced with a functional test due to flakiness.")
async def test_basic_request_local(sample_request: HTTPRequest) -> None:
config = AWSCRTHTTPClientConfig()
session = AWSCRTHTTPClient(client_config=config)
Expand All @@ -15,6 +18,7 @@ async def test_basic_request_local(sample_request: HTTPRequest) -> None:
assert b"aws" in body


@pytest.mark.skip("Needs to be replaced with a functional test due to flakiness.")
async def test_basic_request_http2(sample_request: HTTPRequest) -> None:
config = AWSCRTHTTPClientConfig(force_http_2=True)
session = AWSCRTHTTPClient(client_config=config)
Expand Down

0 comments on commit ccc13e7

Please sign in to comment.