Add timestamp format enum #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `TimestampFormat` enum that provides helper methods for serializaing and deserializing for each format.
nateprewitt
reviewed
May 22, 2024
Comment on lines
70
to
71
| """An HTTP date as defined by the IMF-fixdate production in RFC 7231 section | ||
| 7.1.1.1.""" |
There was a problem hiding this comment.
Should we be using the latest standard here (RFC 9110 5.6.7) or is there a notable difference in the older RFC we use?
There was a problem hiding this comment.
I don't think there's any difference, but I can update the reference here and in the smithy docs.
There was a problem hiding this comment.
nateprewitt
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
TimestampFormatenum that has helper methods on it for serialization and deserialization.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.