Collapse member schemas #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames Schema.type to avoid shadowing the built-in `type`
This changes member schemas to look like their targets, except with the trait lists merged. This is being done to make serialization and deserialization code much simpler. Having to follow member references is a pretty big footgun in Smithy itself, and while it nevertheless makes sense in Smithy, these schemas don't have the same uses case.
nateprewitt
previously approved these changes
May 24, 2024
mtdowling
reviewed
May 24, 2024
nateprewitt
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates schemas in two ways. First, it renames
typetoshape_typeto avoid shadowing the built in, which may be needed for type signatures later. Second, it changes the way members are created. Members now look mostly like their targets, except with different ids and traits. This makes serialization way easier and less prone to errors since implementations no longer have to follow member references to get traits or worry about how to handle overrides.Since the
MEMBERshape type isn't being used, I removed it.I also moved a test file that was in the wrong package for some reason.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.