Remove read_optional in favor of is_null/read_null #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes read_optional in favor of is_null and read_null on shape deserializers. This lets us reduce the number of lambdas and gives us more flexibility. This allows, for example, for skipping nulls in sparse collections.
JordonPhillips
force-pushed
the
use-is-null
branch
from
6b31e75 to
babdbf9
Compare
nateprewitt
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes read_optional in favor of is_null and read_null on shape deserializers. This lets us reduce the number of lambdas created and gives us more flexibility. This allows, for example, for skipping nulls in dense collections.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.