Import AWS protocol framing and event stream support #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings over the protocol framing and event stream support that is currently being used in the transcribe streaming sdk, with some changes from botocore. Minor refactoring has been done to format, add type hints, and to upgrade to some new language features. Some issues reported by the typing have been addressed, mostly accounting for cases where a value could be `None` but wasn't handled as such. More refactoring will be done in future PRs to make all this implement a generic interface. Effort will be made to keep this module free of dependencies, so that it can at least be used by the transcribe sdk, if not botocore.
JordonPhillips
force-pushed
the
event-stream-aws
branch
from
93ae004
to
46772c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings over the protocol framing and event stream support that is currently being used in the transcribe streaming sdk, with some changes from botocore.
Minor refactoring has been done to format, add type hints, and to upgrade to some new language features. Some issues reported by the typing have been addressed, mostly accounting for cases where a value could be
Nonebut wasn't handled as such.More refactoring will be done in future PRs to make all this implement a generic interface. Effort will be made to keep this module free of dependencies, so that it can at least be used by the transcribe sdk, if not botocore.
I had started getting into the weeds of those bigger changes, but I think it's best to see how those changes affect what's already been there.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.