Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip new failing tests #321

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Skip new failing tests #321

merged 1 commit into from
Oct 18, 2024

Conversation

JordonPhillips
Copy link
Contributor

These new tests cover parts of serialization that are slated to be redone soon, so there's little value in fixing them right now.

Separate PR to break it out since so many other PRs are blocked on this

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

These new tests cover parts of serialization that are slated to be
redone soon, so there's little value in fixing them right now.
@JordonPhillips JordonPhillips requested a review from a team as a code owner October 18, 2024 13:56
Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be missing something, but it looks like this already being done in #318 here? Nevermind, mentally parsed out the second line as part of the PR agreement. Good to go 👍

@nateprewitt nateprewitt merged commit c8f423f into develop Oct 18, 2024
5 checks passed
@nateprewitt nateprewitt deleted the suppress-new-protocol-tests branch October 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants