Lock Smithy to a static version #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates our Smithy versioning to a single static version that is not synced via gradle properties. The version currently locked in is 1.52.0, which is not the latest, but 1.52.1 has a bug that prevents us from generating protocol tests. Instead of relying on the version range to keep us up to date, we will now be relying on dependabot. It can also track all the different dependency file locations, which removes the need for the syncing via gradle properties.
nateprewitt
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our Smithy versioning to a single static version that is not synced via gradle properties. The version currently locked in is 1.52.0, which is not the latest, but 1.52.1 has a bug that prevents us from generating protocol tests.
Instead of relying on the version range to keep us up to date, we will now be relying on dependabot. It can also track all the different dependency file locations, which removes the need for the syncing via gradle properties.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.