Skip to content

Commit

Permalink
respond to PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Velfi committed Dec 2, 2024
1 parent 02f1da6 commit ea72d21
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion aws/rust-runtime/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions aws/sdk/integration-tests/s3/tests/signing-it.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@ async fn disable_payload_signing_works() {
assert_eq!("UNSIGNED-PAYLOAD", x_amz_content_sha256);
}

// This test ensures that the interceptor's payload signing setting
// takes priority over the runtime plugin for disabling signing.
// This test ensures that the request checksum interceptor payload signing
// override takes priority over the runtime plugin's override. If it didn't,
// then disabling payload signing would cause requests to incorrectly omit
// trailers.
#[tokio::test]
async fn disable_payload_signing_works_with_checksums() {
let (http_client, request) = capture_request(None);
Expand Down

0 comments on commit ea72d21

Please sign in to comment.