-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tokio::process to allow timeouts to occur #3052
Conversation
8adaa93
to
ed6c0d4
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
ed6c0d4
to
8aef0a5
Compare
8aef0a5
to
c0c4bca
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
c0c4bca
to
2331c34
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
fd89bcf
to
d6fbcc4
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
d6fbcc4
to
656a79a
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
@@ -3,57 +3,20 @@ | |||
* SPDX-License-Identifier: Apache-2.0 | |||
*/ | |||
|
|||
#![cfg(feature = "credentials-process")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question because I don't know: Is this strictly equivalent to adding the same flag to the credential_process
mod
declaration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah
self.inner.write(buf) | ||
self.inner.write_all(buf)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, write
vs. write_all
is such an easy mistake to make.
656a79a
to
08522ec
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
The existing credentials provider was a DOS risk and didn't obey timeout settings because it used
std::timeout::spawn
but relied on a async-based timeout mechanism.Description
tokio::process
insteadTesting
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.