Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clone impl to PresignedRequest #3084

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add Clone impl to PresignedRequest #3084

merged 1 commit into from
Oct 25, 2023

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Oct 20, 2023

Motivation and Context

This makes it easier to convert presigned request into an HTTP request

Description

  • add clone impl
  • add make_presigned_request that borrows from self

Testing

CI

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested a review from a team as a code owner October 20, 2023 19:44
@rcoh rcoh force-pushed the make-presigned-request-clone branch from 5de8b6d to 140b4d0 Compare October 20, 2023 19:46
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh force-pushed the make-presigned-request-clone branch from 140b4d0 to 8188899 Compare October 20, 2023 20:12
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh added the breaking-change This will require a breaking change label Oct 23, 2023
@rcoh rcoh force-pushed the make-presigned-request-clone branch from 8188899 to 370e303 Compare October 23, 2023 15:06
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh mentioned this pull request Oct 25, 2023
9 tasks
@rcoh rcoh force-pushed the make-presigned-request-clone branch from 370e303 to d48642b Compare October 25, 2023 18:28
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh force-pushed the make-presigned-request-clone branch from d48642b to 4b2a726 Compare October 25, 2023 19:02
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh added this pull request to the merge queue Oct 25, 2023
@rcoh rcoh mentioned this pull request Oct 25, 2023
2 tasks
Merged via the queue into main with commit 118151e Oct 25, 2023
@rcoh rcoh deleted the make-presigned-request-clone branch October 25, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants