Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifetimes in structure impl #3106

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add lifetimes in structure impl #3106

merged 1 commit into from
Oct 30, 2023

Conversation

82marbag
Copy link
Contributor


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Daniele Ahmed <[email protected]>
@82marbag 82marbag requested review from a team as code owners October 29, 2023 10:13
@@ -133,7 +133,8 @@ open class StructureGenerator(
if (accessorMembers.isEmpty()) {
return
}
writer.rustBlock("impl $name") {
val lifetimes = lifetimeDeclaration()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: How about we call this the genericParams? Just to be in line with the official specs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are specifically lifetimes (from the docs you linked)

@github-actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@82marbag 82marbag added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 7fb78bb Oct 30, 2023
@82marbag 82marbag deleted the lifetime-struct-impl branch October 30, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants