Allow publisher to put downgraded crates into gradle.properties
#3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this on behalf of PR3316 |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We are currently in a circumstance where we need to publish
0.60.1unstable runtime crates even though0.61.0were published tocrates.ioin the previous release.Description
This PR allows
publisherto specify downgraded runtime crate versions ingradle.propertiesvia the--allow-downgradeflag and updates a scriptupgrade-gradle-propertiesto use that flag. This is a bare minimum change in that we could update a release workflow to have a new checkbox whether we allow downgrade or not and thread through that value to theupgrade-gradle-propertiesscript, instead of directly specifying like so.Testing
Added unit tests for
publisherand manually ranpublisher upgrade-runtime-crates-versionwith--allow-downgradeto check the functionality.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.