-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor hyper1 client builder to allow multiple TLS providers and add new config #3914
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely refactored!
sleep_impl: Option<SharedAsyncSleep>, | ||
client_builder: Option<hyper_util::client::legacy::Builder>, | ||
enable_tcp_nodelay: bool, | ||
interface: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
Motivation and Context
Yet another follow up to: #3866
Description
CryptoMode
but that is only applicable to rustls. I've swapped this for a newTlsProvider
conceptConnector
). But this is structurally awkward since ourConnector
is analogous to hyper_utils'HttpConnector
(or supposed to be anyway). The updated structure forces ourConnector
to build theHttpConnector
(which is the lowest layer/TCP connector) and then (if enabled) wrap it in TLS, and then finally wrap it with the SDK timeouts.TCP_NODELAY
(and defaulted it to true).crypto-aws-lc
->rustls-aws-lc
)NOTE: Apologies in advance, the diff didn't quite come out as I wanted.
client.rs
replacedhyper_1.rs
(several modules ofhyper_1.rs
were split out into new modules). Everything intimeout.rs
anddns.rs
did not change.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.