chore: update url version to v2.5.4 #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryota-sakamoto
force-pushed
the
update-url-aws-config
branch
from
119d075 to
8fb3a32
Compare
ryota-sakamoto
changed the title
|
Looks like most of the failures here are for error in core which should be fixed when #3936 is merged bumping our MSRV to a version that supports that. |
|
Sure, so I'm waiting for it and will update this PR after the merge. |
ryota-sakamoto
force-pushed
the
update-url-aws-config
branch
2 times, most recently
from
64da4f1 to
df8505a
Compare
Signed-off-by: Ryota Sakamoto <[email protected]>
ryota-sakamoto
force-pushed
the
update-url-aws-config
branch
from
df8505a to
40c446a
Compare
landonxjames
approved these changes
Dec 19, 2024
|
Canary succeeded, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
idna0.5.0 whichurldepends on has CVE-2024-12224 so we need to update the crate to v2.5.4.https://rustsec.org/advisories/RUSTSEC-2024-0421
Description
This PR is to update the crate on aws-config, aws-inlineable and inlineable. Because all of them has dependency explicitly. Also I updated Cargo.toml and run
cargo buildon each of them to generate Cargo.lock.Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.