add tracking for checksum algorithm and retry mode business metrics #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
UA metrics for checksums is covered in #3851 and it sitting in the |
landonxjames
approved these changes
Dec 17, 2024
| @@ -130,6 +131,22 @@ where | |||
| cfg: &mut ConfigBag, | |||
| ) -> Result<(), BoxError> { | |||
| let checksum_algorithm = (self.algorithm_provider)(context.input())?; | |||
| if let Some(checksum_algorithm) = checksum_algorithm { | |||
There was a problem hiding this comment.
Would probably remove these changes for now and just roll out this detection with the new flex checksums (mostly in favor of making my merge to the feature branch easier)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds business metric tracking for checksum algorithms and retry modes. This PR includes tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.